From: Daniel Jacobowitz <drow@false.org>
To: zhigang gong <zhigang.gong@gmail.com>,
Corinna Vinschen <vinschen@redhat.com>,
gdb-patches@sources.redhat.com
Subject: Re: Wrong data type in function unpack_varlen_hex()
Date: Thu, 13 Jul 2006 15:36:00 -0000 [thread overview]
Message-ID: <20060713153608.GA26468@nevyn.them.org> (raw)
In-Reply-To: <20060713152349.GA26052@nevyn.them.org>
On Thu, Jul 13, 2006 at 11:23:49AM -0400, Daniel Jacobowitz wrote:
> Corinna, what do you think? The context is the remote protocol reply
> "rwatch:0x80000000"; a bug previously caused this to be sign extended,
> but now that's been fixed. So I'm afraid we now have the same bug you
> were both trying to fix back again.
Maybe we should be using gdbarch_integer_to_address here too?
Or maybe that hook ought to be completely removed and consolidated with
something else. There's a whole bunch of related hooks. With your
recent change, mips_integer_to_address basically matches
signed_pointer_to_address.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-07-13 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-16 12:58 zhigang gong
2006-07-13 4:07 ` Daniel Jacobowitz
2006-07-13 15:19 ` zhigang gong
2006-07-13 15:23 ` Daniel Jacobowitz
2006-07-13 15:36 ` Daniel Jacobowitz [this message]
2006-07-15 10:34 ` zhigang gong
2006-07-17 0:10 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060713153608.GA26468@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vinschen@redhat.com \
--cc=zhigang.gong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox