Re: Wrong data type in function unpack_varlen_hex()

Daniel Jacobowitz
2006-07-13T15:23:58Z

On Thu, Jul 13, 2006 at 11:19:01PM +0800, zhigang gong wrote:
> I have worried about that too. As I foud that in gdb the signed extention
> should
> be the default way. And I also found the watchpoint address
> 0x000000008xxxxxxx was calculated from the address expression, which
> is inputted in the command line as belows:
> gdb ) rwatch *0x8xxxxxxx
> Maybe change the watchpoint address expression calculating, make it
> to do an signed extension, is better.

You may want to test again with HEAD then. As it happens, Corinna
submitted another patch which also went in today, and her patch changes
the MIPS port to sign extend "*0x8xxxxxxx" by default.

Corinna, what do you think? The context is the remote protocol reply
"rwatch:0x80000000"; a bug previously caused this to be sign extended,
but now that's been fixed. So I'm afraid we now have the same bug you
were both trying to fix back again.