From: Daniel Jacobowitz <drow@false.org>
To: zhigang gong <zhigang.gong@gmail.com>,
Corinna Vinschen <vinschen@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Wrong data type in function unpack_varlen_hex()
Date: Thu, 13 Jul 2006 15:23:00 -0000 [thread overview]
Message-ID: <20060713152349.GA26052@nevyn.them.org> (raw)
In-Reply-To: <40c9f5b20607130819u4dba5d48u636ffd1cb99db77f@mail.gmail.com>
On Thu, Jul 13, 2006 at 11:19:01PM +0800, zhigang gong wrote:
> I have worried about that too. As I foud that in gdb the signed extention
> should
> be the default way. And I also found the watchpoint address
> 0x000000008xxxxxxx was calculated from the address expression, which
> is inputted in the command line as belows:
> gdb ) rwatch *0x8xxxxxxx
> Maybe change the watchpoint address expression calculating, make it
> to do an signed extension, is better.
You may want to test again with HEAD then. As it happens, Corinna
submitted another patch which also went in today, and her patch changes
the MIPS port to sign extend "*0x8xxxxxxx" by default.
Corinna, what do you think? The context is the remote protocol reply
"rwatch:0x80000000"; a bug previously caused this to be sign extended,
but now that's been fixed. So I'm afraid we now have the same bug you
were both trying to fix back again.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-07-13 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-16 12:58 zhigang gong
2006-07-13 4:07 ` Daniel Jacobowitz
2006-07-13 15:19 ` zhigang gong
2006-07-13 15:23 ` Daniel Jacobowitz [this message]
2006-07-13 15:36 ` Daniel Jacobowitz
2006-07-15 10:34 ` zhigang gong
2006-07-17 0:10 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060713152349.GA26052@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vinschen@redhat.com \
--cc=zhigang.gong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox