From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12194 invoked by alias); 13 Jul 2006 15:36:13 -0000 Received: (qmail 12087 invoked by uid 22791); 13 Jul 2006 15:36:13 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 13 Jul 2006 15:36:11 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G13EW-0006uJ-Sp; Thu, 13 Jul 2006 11:36:08 -0400 Date: Thu, 13 Jul 2006 15:36:00 -0000 From: Daniel Jacobowitz To: zhigang gong , Corinna Vinschen , gdb-patches@sources.redhat.com Subject: Re: Wrong data type in function unpack_varlen_hex() Message-ID: <20060713153608.GA26468@nevyn.them.org> Mail-Followup-To: zhigang gong , Corinna Vinschen , gdb-patches@sources.redhat.com References: <40c9f5b20606160558v277bb813r9d5a497c9899432@mail.gmail.com> <20060713040658.GZ24622@nevyn.them.org> <40c9f5b20607130819u4dba5d48u636ffd1cb99db77f@mail.gmail.com> <20060713152349.GA26052@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060713152349.GA26052@nevyn.them.org> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00155.txt.bz2 On Thu, Jul 13, 2006 at 11:23:49AM -0400, Daniel Jacobowitz wrote: > Corinna, what do you think? The context is the remote protocol reply > "rwatch:0x80000000"; a bug previously caused this to be sign extended, > but now that's been fixed. So I'm afraid we now have the same bug you > were both trying to fix back again. Maybe we should be using gdbarch_integer_to_address here too? Or maybe that hook ought to be completely removed and consolidated with something else. There's a whole bunch of related hooks. With your recent change, mips_integer_to_address basically matches signed_pointer_to_address. -- Daniel Jacobowitz CodeSourcery