Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Mitchell <mark@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Disable ARM RDP
Date: Fri, 24 Mar 2006 21:36:00 -0000	[thread overview]
Message-ID: <20060324203053.GC26748@nevyn.them.org> (raw)
In-Reply-To: <200603172225.k2HMPgPG024087@sethra.codesourcery.com>

On Fri, Mar 17, 2006 at 02:25:42PM -0800, Mark Mitchell wrote:
> 
> This patch removes remote-rdp.o from ARM's TDEPFILES since Daniel and
> Paul say that it's useless to most people.  I also found that with
> --disable-sim GDB fails to link because remote-rdp.c references a
> function defined in the simulator.
> 
> I'm not sure if this is the right patch for mainline, or whether
> people would rather I remove remote-rdp.c entirely, or do nothing, or
> ...  So, I guess this is a request for approval, but a pretty
> tentative one.

> 	* gdb/config/arm/embed.mt (TDEPFILES): Remove remote-rdp.o.

Well, this patch isn't OK.  Afterwards remote-rdp is orphaned - no
other configuration uses it.  So, either we are removing it, or we
aren't.

I'm in favor of removing it.  Strikes against it:

  - It doesn't build with --disable-sim.
  - It doesn't build on some versions of MinGW32, because it
    references sleep().
  - It's an old remote protocol and I haven't seen any reports of
    it being used.
  - Using RDP directly is even older than using RDI to talk to
    the same devices, which we've already removed.

I have no real preference on removing it immediately versus marking it
obsolete in the next release; the first two bullets are problems for
CodeSourcery, but we can always turn it off in our release branch.
But I'd like to do one or the other.  Anyone have a preference?

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-03-24 20:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-18  2:40 Mark Mitchell
2006-03-24 21:36 ` Daniel Jacobowitz [this message]
2006-04-11 20:00   ` Daniel Jacobowitz
2006-05-05 19:58     ` Daniel Jacobowitz
2006-05-17 14:53       ` Daniel Jacobowitz
2006-05-17 18:36         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060324203053.GC26748@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mark@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox