Re: PATCH: Disable ARM RDP

[Daniel Jacobowitz <drow@false.org>]

On Tue, Apr 11, 2006 at 04:00:09PM -0400, Daniel Jacobowitz wrote:
> I didn't see any comments on this.  I'm pretty confident that no one
> uses this protocol any more, so I would like to remove it, unless
> anyone objects.
> 
> So, please speak up, if you object to "target rdp" being removed from
> the arm-elf target.  No other triplet enables it.

Lacking objections, I plan to apply this patch next week.  Does anyone
have a last call for RDP?  NEWS addition OK?

-- 
Daniel Jacobowitz
CodeSourcery

2006-05-05  Daniel Jacobowitz  <dan@codesourcery.com>

	* remote-rdp.c: Deleted.
	* NEWS: Mention removal of remote-rdp.c.

	* Makefile.in (ALLDEPFILES): Remove remote-rdp.c.
	(remote-rdp.o): Delete.
	* README: Remove description of remote-rdp.c.
	* arm-tdep.c (arm_breakpoint_from_pc): Remove obsolete comment.
	* config/arm/embed.mt (TDEPFILES): Remove remote-rdp.o.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.811
diff -u -p -r1.811 Makefile.in
--- Makefile.in	23 Apr 2006 14:15:01 -0000	1.811
+++ Makefile.in	5 May 2006 19:55:53 -0000
@@ -1449,7 +1449,7 @@ ALLDEPFILES = \
 	procfs.c \
 	remote-e7000.c \
 	remote-hms.c remote-m32r-sdi.c remote-mips.c \
-	remote-rdp.c remote-sim.c \
+	remote-sim.c \
 	remote-st.c remote-utils.c dcache.c \
 	rs6000-nat.c rs6000-tdep.c \
 	s390-tdep.c s390-nat.c \
@@ -2485,9 +2485,6 @@ remote-mips.o: remote-mips.c $(defs_h) $
 	$(gdbcmd_h) $(gdbcore_h) $(serial_h) $(target_h) $(exceptions_h) \
 	$(remote_utils_h) $(gdb_string_h) $(gdb_stat_h) $(regcache_h) \
 	$(mips_tdep_h)
-remote-rdp.o: remote-rdp.c $(defs_h) $(inferior_h) $(value_h) \
-	$(gdb_callback_h) $(command_h) $(symfile_h) $(remote_utils_h) \
-	$(gdb_string_h) $(gdbcore_h) $(regcache_h) $(serial_h) $(arm_tdep_h)
 remote-sds.o: remote-sds.c $(defs_h) $(gdb_string_h) $(frame_h) \
 	$(inferior_h) $(exceptions_h) $(bfd_h) $(symfile_h) $(target_h) \
 	$(gdbcmd_h) $(objfiles_h) $(gdb_stabs_h) $(gdbthread_h) $(gdbcore_h) \
Index: NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.186
diff -u -p -r1.186 NEWS
--- NEWS	20 Apr 2006 23:18:48 -0000	1.186
+++ NEWS	5 May 2006 19:55:53 -0000
@@ -59,6 +59,8 @@ The ARM rdi-share module.
 
 The Netware NLM debug server.
 
+The ARM Demon monitor support ("target rdp").
+
 *** Changes in GDB 6.4
 
 * New native configurations
Index: README
===================================================================
RCS file: /cvs/src/src/gdb/README,v
retrieving revision 1.35
diff -u -p -r1.35 README
--- README	21 Jan 2006 01:29:03 -0000	1.35
+++ README	5 May 2006 19:55:54 -0000
@@ -454,7 +454,6 @@ monitors and other hardware:
 	remote-est.c	 EST emulator
 	remote-hms.c	 Renesas Micro Systems H8/300 monitor
 	remote-mips.c	 MIPS remote debugging protocol
-	remote-rdp.c	 ARM with Demon monitor
 	remote-sds.c	 PowerPC SDS monitor
 	remote-sim.c	 Generalized simulator protocol
 	remote-st.c	 Tandem ST-2000 monitor
Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.208
diff -u -p -r1.208 arm-tdep.c
--- arm-tdep.c	18 Apr 2006 19:20:05 -0000	1.208
+++ arm-tdep.c	5 May 2006 19:55:54 -0000
@@ -1964,11 +1964,6 @@ static const char arm_default_thumb_be_b
    necessary) to point to the actual memory location where the
    breakpoint should be inserted.  */
 
-/* XXX ??? from old tm-arm.h: if we're using RDP, then we're inserting
-   breakpoints and storing their handles instread of what was in
-   memory.  It is nice that this is the same size as a handle -
-   otherwise remote-rdp will have to change.  */
-
 static const unsigned char *
 arm_breakpoint_from_pc (CORE_ADDR *pcptr, int *lenptr)
 {
Index: config/arm/embed.mt
===================================================================
RCS file: /cvs/src/src/gdb/config/arm/embed.mt,v
retrieving revision 1.3
diff -u -p -r1.3 embed.mt
--- config/arm/embed.mt	21 Jan 2006 01:29:04 -0000	1.3
+++ config/arm/embed.mt	5 May 2006 19:55:54 -0000
@@ -1,5 +1,5 @@
 # Target: ARM embedded system
-TDEPFILES= arm-tdep.o remote-rdp.o
+TDEPFILES= arm-tdep.o
 DEPRECATED_TM_FILE= tm-embed.h
 
 SIM_OBS = remote-sim.o