From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11840 invoked by alias); 24 Mar 2006 20:30:58 -0000 Received: (qmail 11831 invoked by uid 22791); 24 Mar 2006 20:30:57 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 24 Mar 2006 20:30:56 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FMsvt-0007Aa-9z; Fri, 24 Mar 2006 15:30:53 -0500 Date: Fri, 24 Mar 2006 21:36:00 -0000 From: Daniel Jacobowitz To: Mark Mitchell Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Disable ARM RDP Message-ID: <20060324203053.GC26748@nevyn.them.org> Mail-Followup-To: Mark Mitchell , gdb-patches@sources.redhat.com References: <200603172225.k2HMPgPG024087@sethra.codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200603172225.k2HMPgPG024087@sethra.codesourcery.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00275.txt.bz2 On Fri, Mar 17, 2006 at 02:25:42PM -0800, Mark Mitchell wrote: > > This patch removes remote-rdp.o from ARM's TDEPFILES since Daniel and > Paul say that it's useless to most people. I also found that with > --disable-sim GDB fails to link because remote-rdp.c references a > function defined in the simulator. > > I'm not sure if this is the right patch for mainline, or whether > people would rather I remove remote-rdp.c entirely, or do nothing, or > ... So, I guess this is a request for approval, but a pretty > tentative one. > * gdb/config/arm/embed.mt (TDEPFILES): Remove remote-rdp.o. Well, this patch isn't OK. Afterwards remote-rdp is orphaned - no other configuration uses it. So, either we are removing it, or we aren't. I'm in favor of removing it. Strikes against it: - It doesn't build with --disable-sim. - It doesn't build on some versions of MinGW32, because it references sleep(). - It's an old remote protocol and I haven't seen any reports of it being used. - Using RDP directly is even older than using RDI to talk to the same devices, which we've already removed. I have no real preference on removing it immediately versus marking it obsolete in the next release; the first two bullets are problems for CodeSourcery, but we can always turn it off in our release branch. But I'd like to do one or the other. Anyone have a preference? -- Daniel Jacobowitz CodeSourcery