Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: randolph@tausq.org
Cc: gdb-patches@sources.redhat.com, dave@hiauly1.hia.nrc.ca
Subject: Re: [hpux] Fix build problem on hpux
Date: Thu, 09 Mar 2006 19:14:00 -0000	[thread overview]
Message-ID: <200603091908.k29J8E67001447@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <44104BCC.8060700@tausq.org> (message from Randolph Chung on Thu, 	09 Mar 2006 23:37:48 +0800)

> Date: Thu, 09 Mar 2006 23:37:48 +0800
> From: Randolph Chung <randolph@tausq.org>
> 
> This fixes the build problem on HPUX reported recently by Dave Anglin 
> (PR/2097). Thanks to Dave for debugging the problem :)
> 
> I'll check this in in a few days unless I hear objections.
>
> Index: config/pa/hppahpux.mt
> ===================================================================
> RCS file: /cvs/src/src/gdb/config/pa/hppahpux.mt,v
> retrieving revision 1.7
> diff -u -p -r1.7 hppahpux.mt
> --- config/pa/hppahpux.mt	13 Dec 2004 04:06:16 -0000	1.7
> +++ config/pa/hppahpux.mt	9 Mar 2006 15:28:16 -0000
> @@ -1,4 +1,4 @@
>  # Target: HP PA-RISC running hpux
> -MT_CFLAGS = -DPA_SOM_ONLY=1
> +MT_CFLAGS = -DPA_SOM_ONLY=1 -D_XOPEN_SOURCE_EXTENDED
>  TDEPFILES= hppa-tdep.o hppa-hpux-tdep.o corelow.o somread.o hpread.o solib-som.o solib-pa64.o solib.o
>  DEPRECATED_TM_FILE= tm-hppah.h

This can't be right.  The point is to add -D_XOPEN_SOURCE_EXTENDED
whenever we compile *on* HP-UX, not whenever we're targeting HP-UX.
This should be handled using autoconf, much in the same way as we do
for _GNU_SOURCE, since it affects the functionality made available by
the OS.

The other bit of the patch is ok of course, so you might as well check
that bit in.

Mark


  reply	other threads:[~2006-03-09 19:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-09 18:05 Randolph Chung
2006-03-09 19:14 ` Mark Kettenis [this message]
2006-03-10  1:35   ` Randolph Chung
2006-03-10  1:48     ` John David Anglin
2006-03-10  2:33       ` Randolph Chung
2006-03-10 11:15         ` John David Anglin
2006-03-10 12:50     ` Daniel Jacobowitz
     [not found]       ` <4410EE58.1060007@tausq.org>
     [not found]         ` <20060310035929.GA12013@nevyn.them.org>
     [not found]           ` <4410FF26.40509@tausq.org>
2006-03-26  8:33             ` Randolph Chung
2006-03-28 22:29               ` Daniel Jacobowitz
2006-03-29  0:28                 ` Randolph Chung
2006-03-29  4:36                   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200603091908.k29J8E67001447@elgar.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=dave@hiauly1.hia.nrc.ca \
    --cc=gdb-patches@sources.redhat.com \
    --cc=randolph@tausq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox