From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13799 invoked by alias); 9 Mar 2006 19:08:29 -0000 Received: (qmail 13788 invoked by uid 22791); 9 Mar 2006 19:08:28 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 09 Mar 2006 19:08:25 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k29J8Eqt017570; Thu, 9 Mar 2006 20:08:14 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id k29J8EOf026221; Thu, 9 Mar 2006 20:08:14 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id k29J8E67001447; Thu, 9 Mar 2006 20:08:14 +0100 (CET) Date: Thu, 09 Mar 2006 19:14:00 -0000 Message-Id: <200603091908.k29J8E67001447@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: randolph@tausq.org CC: gdb-patches@sources.redhat.com, dave@hiauly1.hia.nrc.ca In-reply-to: <44104BCC.8060700@tausq.org> (message from Randolph Chung on Thu, 09 Mar 2006 23:37:48 +0800) Subject: Re: [hpux] Fix build problem on hpux References: <44104BCC.8060700@tausq.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00141.txt.bz2 > Date: Thu, 09 Mar 2006 23:37:48 +0800 > From: Randolph Chung > > This fixes the build problem on HPUX reported recently by Dave Anglin > (PR/2097). Thanks to Dave for debugging the problem :) > > I'll check this in in a few days unless I hear objections. > > Index: config/pa/hppahpux.mt > =================================================================== > RCS file: /cvs/src/src/gdb/config/pa/hppahpux.mt,v > retrieving revision 1.7 > diff -u -p -r1.7 hppahpux.mt > --- config/pa/hppahpux.mt 13 Dec 2004 04:06:16 -0000 1.7 > +++ config/pa/hppahpux.mt 9 Mar 2006 15:28:16 -0000 > @@ -1,4 +1,4 @@ > # Target: HP PA-RISC running hpux > -MT_CFLAGS = -DPA_SOM_ONLY=1 > +MT_CFLAGS = -DPA_SOM_ONLY=1 -D_XOPEN_SOURCE_EXTENDED > TDEPFILES= hppa-tdep.o hppa-hpux-tdep.o corelow.o somread.o hpread.o solib-som.o solib-pa64.o solib.o > DEPRECATED_TM_FILE= tm-hppah.h This can't be right. The point is to add -D_XOPEN_SOURCE_EXTENDED whenever we compile *on* HP-UX, not whenever we're targeting HP-UX. This should be handled using autoconf, much in the same way as we do for _GNU_SOURCE, since it affects the functionality made available by the OS. The other bit of the patch is ok of course, so you might as well check that bit in. Mark