From: Randolph Chung <randolph@tausq.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [hpux] Fix build problem on hpux
Date: Wed, 29 Mar 2006 00:28:00 -0000 [thread overview]
Message-ID: <4429CEFE.50103@tausq.org> (raw)
In-Reply-To: <20060328221800.GA11817@nevyn.them.org>
Daniel Jacobowitz wrote:
> On Sun, Mar 26, 2006 at 03:55:48PM +0800, Randolph Chung wrote:
>
>>+# When building on HPUX, we need to define _XOPEN_SOURCE_EXTENDED to get
>>+# proper prototypes.
>>+case $host_os in
>>+hpux*)
>>+ AH_VERBATIM([_XOPEN_SOURCE_EXTENDED],
>>+ [/* Define to 1 if on HPUX. */
>>+#ifndef _XOPEN_SOURCE_EXTENDED
>>+# undef _XOPEN_SOURCE_EXTENDED
>>+#endif])dnl
>>+ AC_DEFINE([_XOPEN_SOURCE_EXTENDED])
>>+ ;;
>>+esac
>
>
> I am most confused as to what you are trying to do. You should leave
> _XOPEN_SOURCE_EXTENDED alone on non-HP/UX, and make sure it is
> appropriately defined on HP/UX.
Yes, this is exactly what I am trying to do. What is confusing.
> #ifndef followed by #undef doesn't
> do much. And I don't think AH_VERBATIM does what you think; it changes
> the generated config.in, not the generated config.h, so it affects all
> platforms.
Yes, I know. Normally autoheader will generate just the #undef line;
the above makes it generate the #undef inside the #ifndef. This is the
same logic used to generate the _GNU_SOURCE #define in config.in. The
#undef is changed into a #define by configure on hpux. On other systems,
you are right that the three lines don't do anything, and that is the
desired effect.
The problem is that we are trying to avoid a redefinition of
_XOPEN_SOURCE_EXTENDED, in case this define is by default enabled on a
particular platform.
randolph
next prev parent reply other threads:[~2006-03-29 0:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 18:05 Randolph Chung
2006-03-09 19:14 ` Mark Kettenis
2006-03-10 1:35 ` Randolph Chung
2006-03-10 1:48 ` John David Anglin
2006-03-10 2:33 ` Randolph Chung
2006-03-10 11:15 ` John David Anglin
2006-03-10 12:50 ` Daniel Jacobowitz
[not found] ` <4410EE58.1060007@tausq.org>
[not found] ` <20060310035929.GA12013@nevyn.them.org>
[not found] ` <4410FF26.40509@tausq.org>
2006-03-26 8:33 ` Randolph Chung
2006-03-28 22:29 ` Daniel Jacobowitz
2006-03-29 0:28 ` Randolph Chung [this message]
2006-03-29 4:36 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4429CEFE.50103@tausq.org \
--to=randolph@tausq.org \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox