Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [hpux] Fix build problem on hpux
Date: Tue, 28 Mar 2006 22:29:00 -0000	[thread overview]
Message-ID: <20060328221800.GA11817@nevyn.them.org> (raw)
In-Reply-To: <44264904.6000005@tausq.org>

On Sun, Mar 26, 2006 at 03:55:48PM +0800, Randolph Chung wrote:
> +# When building on HPUX, we need to define _XOPEN_SOURCE_EXTENDED to get
> +# proper prototypes.
> +case $host_os in
> +hpux*)
> +    AH_VERBATIM([_XOPEN_SOURCE_EXTENDED],
> +    [/* Define to 1 if on HPUX.  */
> +#ifndef _XOPEN_SOURCE_EXTENDED
> +# undef _XOPEN_SOURCE_EXTENDED
> +#endif])dnl
> +    AC_DEFINE([_XOPEN_SOURCE_EXTENDED])
> +  ;;
> +esac

I am most confused as to what you are trying to do.  You should leave
_XOPEN_SOURCE_EXTENDED alone on non-HP/UX, and make sure it is
appropriately defined on HP/UX.  #ifndef followed by #undef doesn't
do much.  And I don't think AH_VERBATIM does what you think; it changes
the generated config.in, not the generated config.h, so it affects all
platforms.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-03-28 22:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-09 18:05 Randolph Chung
2006-03-09 19:14 ` Mark Kettenis
2006-03-10  1:35   ` Randolph Chung
2006-03-10  1:48     ` John David Anglin
2006-03-10  2:33       ` Randolph Chung
2006-03-10 11:15         ` John David Anglin
2006-03-10 12:50     ` Daniel Jacobowitz
     [not found]       ` <4410EE58.1060007@tausq.org>
     [not found]         ` <20060310035929.GA12013@nevyn.them.org>
     [not found]           ` <4410FF26.40509@tausq.org>
2006-03-26  8:33             ` Randolph Chung
2006-03-28 22:29               ` Daniel Jacobowitz [this message]
2006-03-29  0:28                 ` Randolph Chung
2006-03-29  4:36                   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060328221800.GA11817@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=randolph@tausq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox