From: Daniel Jacobowitz <drow@false.org>
To: Fred Fish <fnf@diveadx.com>
Cc: Jim Blandy <jimb@red-bean.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix ptype problem printing typedefs defined differently in different compilation units
Date: Sat, 18 Feb 2006 22:19:00 -0000 [thread overview]
Message-ID: <20060218221908.GA31142@nevyn.them.org> (raw)
In-Reply-To: <200602161916.00761.fnf@diveadx.com>
On Thu, Feb 16, 2006 at 07:16:00PM -0500, Fred Fish wrote:
> On Tuesday 14 February 2006 09:10, Daniel Jacobowitz wrote:
> > This patch seems OK to me; but we really ought to fix up the comment
> > directly above this code that you're changing.
>
> I've think it would be best to split work on this issue up into two parts
>
> (1) Make ptype and whatis handle the same arguments. Currently ptype
> will work on typedefs, but whatis does not. This is the change that
> makes them both use whatis_exp and eliminates ptype_eval.
>
> (2) Make ptype and whatis handle printing types specified in a given
> context using 'file'::type. I have a fix that involves a fairly
> minor change to the parser and makes the patch you are commenting on
> obsolete.
>
> Here is the patch for (1). I believe we previously reached on consensus
> that this change was OK, so I'd like to get it checked in. I added some
> testsuite support for testing how whatis behaves with typedef names.
I didn't see any followups to this except for the docs, but I've got no
objection, so it's just as well you've checked it in :-)
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-02-18 22:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-03 20:17 Fred Fish
2006-01-03 23:15 ` Jim Blandy
2006-01-04 2:46 ` Fred Fish
2006-01-04 3:45 ` Jim Blandy
2006-01-04 11:15 ` Fred Fish
2006-01-04 21:04 ` Fred Fish
2006-01-05 0:21 ` Jim Blandy
2006-01-05 0:26 ` Jim Blandy
2006-01-05 0:54 ` Daniel Jacobowitz
2006-01-05 4:47 ` Jim Blandy
2006-01-15 18:48 ` Daniel Jacobowitz
2006-01-16 4:22 ` Jim Blandy
2006-01-23 15:27 ` Fred Fish
2006-01-23 16:12 ` Daniel Jacobowitz
2006-01-23 16:43 ` Fred Fish
2006-01-23 19:17 ` Jim Blandy
2006-01-23 19:35 ` Fred Fish
2006-01-23 20:45 ` Jim Blandy
2006-02-11 0:39 ` Fred Fish
2006-02-11 18:35 ` Daniel Jacobowitz
2006-02-11 19:08 ` Eli Zaretskii
2006-02-11 20:13 ` Daniel Jacobowitz
2006-02-11 20:01 ` Fred Fish
2006-02-11 20:21 ` Daniel Jacobowitz
2006-02-12 18:49 ` Fred Fish
2006-02-14 14:11 ` Daniel Jacobowitz
2006-02-14 18:47 ` Fred Fish
2006-02-17 0:17 ` Fred Fish
2006-02-17 9:15 ` Eli Zaretskii
2006-02-17 13:36 ` Fred Fish
2006-02-17 20:32 ` Fred Fish
2006-02-18 9:27 ` Eli Zaretskii
2006-02-18 22:19 ` Daniel Jacobowitz [this message]
2006-02-20 15:47 ` Fred Fish
2006-02-20 16:23 ` Daniel Jacobowitz
2006-05-17 19:04 ` Fred Fish
2006-02-11 0:39 ` Fred Fish
2006-01-24 15:23 ` [commit] " Fred Fish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060218221908.GA31142@nevyn.them.org \
--to=drow@false.org \
--cc=fnf@diveadx.com \
--cc=gdb-patches@sourceware.org \
--cc=jimb@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox