From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32483 invoked by alias); 18 Feb 2006 22:19:13 -0000 Received: (qmail 32469 invoked by uid 22791); 18 Feb 2006 22:19:12 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 18 Feb 2006 22:19:11 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FAaQ0-00089R-53; Sat, 18 Feb 2006 17:19:08 -0500 Date: Sat, 18 Feb 2006 22:19:00 -0000 From: Daniel Jacobowitz To: Fred Fish Cc: Jim Blandy , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix ptype problem printing typedefs defined differently in different compilation units Message-ID: <20060218221908.GA31142@nevyn.them.org> Mail-Followup-To: Fred Fish , Jim Blandy , gdb-patches@sourceware.org References: <200601031517.50309.fnf@specifix.com> <200602121349.07257.fnf@specifix.com> <20060214141056.GB21812@nevyn.them.org> <200602161916.00761.fnf@diveadx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200602161916.00761.fnf@diveadx.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00348.txt.bz2 On Thu, Feb 16, 2006 at 07:16:00PM -0500, Fred Fish wrote: > On Tuesday 14 February 2006 09:10, Daniel Jacobowitz wrote: > > This patch seems OK to me; but we really ought to fix up the comment > > directly above this code that you're changing. > > I've think it would be best to split work on this issue up into two parts > > (1) Make ptype and whatis handle the same arguments. Currently ptype > will work on typedefs, but whatis does not. This is the change that > makes them both use whatis_exp and eliminates ptype_eval. > > (2) Make ptype and whatis handle printing types specified in a given > context using 'file'::type. I have a fix that involves a fairly > minor change to the parser and makes the patch you are commenting on > obsolete. > > Here is the patch for (1). I believe we previously reached on consensus > that this change was OK, so I'd like to get it checked in. I added some > testsuite support for testing how whatis behaves with typedef names. I didn't see any followups to this except for the docs, but I've got no objection, so it's just as well you've checked it in :-) -- Daniel Jacobowitz CodeSourcery