Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: fnf@diveadx.com
Cc: jimb@red-bean.com, gdb-patches@sourceware.org, fnf@specifix.com
Subject: Re: [PATCH] Fix ptype problem printing typedefs defined differently in different compilation units
Date: Sat, 18 Feb 2006 09:27:00 -0000	[thread overview]
Message-ID: <u3bihggpq.fsf@gnu.org> (raw)
In-Reply-To: <200602171531.27812.fnf@diveadx.com> (message from Fred Fish on 	Fri, 17 Feb 2006 15:31:27 -0500)

> From: Fred Fish <fnf@diveadx.com>
> Date: Fri, 17 Feb 2006 15:31:27 -0500
> Cc: drow@false.org, jimb@red-bean.com, gdb-patches@sourceware.org,
>         fnf@specifix.com
> 
> On Friday 17 February 2006 04:15, Eli Zaretskii wrote:
> > Will the manual's description of the differences between these two
> > commands be still valid after this change?
> 
> Here is a patch for the doc change.

Thanks.  The doc patch is approved, but please take care of this minor
issue:

>   @kindex whatis
>   @item whatis @var{expr}
> ! @itemx whatis @var{typename}
> ! @itemx whatis
> ! Print the data type of expression @var{expr} or type @var{typename}.
> ! @var{expr} is not actually evaluated, and any side-effecting operations
> ! (such as assignments or function calls) inside it do not take place.
> ! @var{typename} may be the name of a type or typedef, or for C code it may
> ! have the form @samp{class @var{class-name}}, @samp{struct @var{struct-tag}},
> ! @samp{union @var{union-tag}} or @samp{enum @var{enum-tag}}.
> ! Without any arguments, print the data type of @code{$}, the last value
> ! in the value history.

Now that you've unified the descriptions, there's no need to have a
separate "@itemx whatis" without arguments, you can simply put the
argument in the other two @item's in [], to show that they are
optional.  I would even leave only one @item, and modify the
description slightly, like this:

  @item whatis [@var{arg}]
  Print the data type of expression @var{arg}, either an expression or
  a data type.  With no argument, print the data type of @code{$}, ...
  If @var{arg} is an expression, it is not actually evaluated, ...  If
  @var{arg} is a type name, it may be the name of a type or typedef, ...


>   @item ptype @var{expr}
> + @itemx ptype @var{typename}
>   @itemx ptype
> ! @code{ptype} accepts the same arguments as @code{whatis}, but prints a
> ! detailed description of the type, instead of just the name of the type.
> ! @xref{Expressions, ,Expressions}.

Same here.


  reply	other threads:[~2006-02-18  9:27 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-03 20:17 Fred Fish
2006-01-03 23:15 ` Jim Blandy
2006-01-04  2:46   ` Fred Fish
2006-01-04  3:45     ` Jim Blandy
2006-01-04 11:15       ` Fred Fish
2006-01-04 21:04       ` Fred Fish
2006-01-05  0:21         ` Jim Blandy
2006-01-05  0:26         ` Jim Blandy
2006-01-05  0:54           ` Daniel Jacobowitz
2006-01-05  4:47             ` Jim Blandy
2006-01-15 18:48         ` Daniel Jacobowitz
2006-01-16  4:22           ` Jim Blandy
2006-01-23 15:27             ` Fred Fish
2006-01-23 16:12               ` Daniel Jacobowitz
2006-01-23 16:43                 ` Fred Fish
2006-01-23 19:17                   ` Jim Blandy
2006-01-23 19:35                     ` Fred Fish
2006-01-23 20:45                       ` Jim Blandy
2006-02-11  0:39                         ` Fred Fish
2006-02-11 18:35                           ` Daniel Jacobowitz
2006-02-11 19:08                             ` Eli Zaretskii
2006-02-11 20:13                               ` Daniel Jacobowitz
2006-02-11 20:01                             ` Fred Fish
2006-02-11 20:21                               ` Daniel Jacobowitz
2006-02-12 18:49                                 ` Fred Fish
2006-02-14 14:11                                   ` Daniel Jacobowitz
2006-02-14 18:47                                     ` Fred Fish
2006-02-17  0:17                                     ` Fred Fish
2006-02-17  9:15                                       ` Eli Zaretskii
2006-02-17 13:36                                         ` Fred Fish
2006-02-17 20:32                                         ` Fred Fish
2006-02-18  9:27                                           ` Eli Zaretskii [this message]
2006-02-18 22:19                                       ` Daniel Jacobowitz
2006-02-20 15:47                                       ` Fred Fish
2006-02-20 16:23                                         ` Daniel Jacobowitz
2006-05-17 19:04                                           ` Fred Fish
2006-02-11  0:39                         ` Fred Fish
2006-01-24 15:23                     ` [commit] " Fred Fish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u3bihggpq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=fnf@diveadx.com \
    --cc=fnf@specifix.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jimb@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox