RFC: Disable pointer signedness warnings

RFC: Disable pointer signedness warnings

[Jim Blandy]

Just to push the group a little further towards making a decision,
here's a patch:

gdb/ChangeLog:
2006-01-18  Jim Blandy  <jimb@redhat.com>

	* configure.ac: Add -Wno-pointer-sign to list of build warnings.
	* configure: Regenerated.

gdb/doc/ChangeLog:
2006-01-18  Jim Blandy  <jimb@redhat.com>

	* gdbint.texinfo (Coding): Add entry for -Wno-pointer-sign to list
	of warning flags.

Index: gdb/configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.25
diff -c -p -r1.25 configure.ac
*** gdb/configure.ac	17 Dec 2005 22:33:59 -0000	1.25
--- gdb/configure.ac	18 Jan 2006 22:00:50 -0000
*************** AC_SUBST(TARGET_SYSTEM_ROOT_DEFINE)
*** 1115,1121 ****
  # gdb/doc/gdbint.texinfo.
  build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \
  -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral \
! -Wunused-label -Wunused-function"

  # GCC supports -Wuninitialized only with -O or -On, n != 0.
  if test x${CFLAGS+set} = xset; then
--- 1115,1121 ----
  # gdb/doc/gdbint.texinfo.
  build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \
  -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral \
! -Wunused-label -Wunused-function -Wno-pointer-sign"

  # GCC supports -Wuninitialized only with -O or -On, n != 0.
  if test x${CFLAGS+set} = xset; then
Index: gdb/doc/gdbint.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.234
diff -c -p -r1.234 gdbint.texinfo
*** gdb/doc/gdbint.texinfo	4 Jan 2006 19:31:27 -0000	1.234
--- gdb/doc/gdbint.texinfo	18 Jan 2006 22:00:54 -0000
*************** switch (sched)
*** 5016,5021 ****
--- 5016,5030 ----
  @end smallexample

  @item -Wunused-function
+
+ @item -Wno-pointer-sign
+ In version 4.0, GCC began warning about pointer argument passing or
+ assignment even when the source and destination differed only in
+ signedness.  However, most @value{GDBN} code doesn't distinguish
+ carefully between @code{char} and @code{unsigned char}.  In early 2006
+ the @value{GDBN} developers decided correcting these warnings wasn't
+ worth the time it would take.
+
  @end table

  @emph{Pragmatics: Due to the way that @value{GDBN} is implemented most

Re: RFC: Disable pointer signedness warnings

[Eli Zaretskii]

> Date: Wed, 18 Jan 2006 16:51:41 -0800
> From: Jim Blandy <jimb@red-bean.com>
> 
> Just to push the group a little further towards making a decision,
> here's a patch:

Fine with me, thanks.

Re: RFC: Disable pointer signedness warnings

[Daniel Jacobowitz]

On Wed, Jan 18, 2006 at 04:51:41PM -0800, Jim Blandy wrote:
> Just to push the group a little further towards making a decision,
> here's a patch:
> 
> gdb/ChangeLog:
> 2006-01-18  Jim Blandy  <jimb@redhat.com>
> 
> 	* configure.ac: Add -Wno-pointer-sign to list of build warnings.
> 	* configure: Regenerated.
> 
> gdb/doc/ChangeLog:
> 2006-01-18  Jim Blandy  <jimb@redhat.com>
> 
> 	* gdbint.texinfo (Coding): Add entry for -Wno-pointer-sign to list
> 	of warning flags.

Everyone who's responded is now in favor of this patch; could you check
it in?

After that I have a tiny handful of warnings on the ARM port which I'll
fix later.  I don't know if there was a consensus on Mark's -Werror
patch, but I agree with him that it's about time to bite the bullet and
do it; but it would be nice if someone ran through gdb_mbuild.sh first
(after Jim's patch is applied) and fixed up the cross configurations.

-- 
Daniel Jacobowitz
CodeSourcery

Re: RFC: Disable pointer signedness warnings

[Jim Blandy]

On 1/20/06, Daniel Jacobowitz <drow@false.org> wrote:
> Everyone who's responded is now in favor of this patch; could you check
> it in?

... What patch?  Oh, THAT patch.  Committed.