Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@red-bean.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: RFC: Disable pointer signedness warnings
Date: Thu, 19 Jan 2006 00:51:00 -0000	[thread overview]
Message-ID: <8f2776cb0601181651m5892f93wf756703b7e4b261a@mail.gmail.com> (raw)

Just to push the group a little further towards making a decision,
here's a patch:

gdb/ChangeLog:
2006-01-18  Jim Blandy  <jimb@redhat.com>

	* configure.ac: Add -Wno-pointer-sign to list of build warnings.
	* configure: Regenerated.

gdb/doc/ChangeLog:
2006-01-18  Jim Blandy  <jimb@redhat.com>

	* gdbint.texinfo (Coding): Add entry for -Wno-pointer-sign to list
	of warning flags.

Index: gdb/configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.25
diff -c -p -r1.25 configure.ac
*** gdb/configure.ac	17 Dec 2005 22:33:59 -0000	1.25
--- gdb/configure.ac	18 Jan 2006 22:00:50 -0000
*************** AC_SUBST(TARGET_SYSTEM_ROOT_DEFINE)
*** 1115,1121 ****
  # gdb/doc/gdbint.texinfo.
  build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \
  -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral \
! -Wunused-label -Wunused-function"

  # GCC supports -Wuninitialized only with -O or -On, n != 0.
  if test x${CFLAGS+set} = xset; then
--- 1115,1121 ----
  # gdb/doc/gdbint.texinfo.
  build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \
  -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral \
! -Wunused-label -Wunused-function -Wno-pointer-sign"

  # GCC supports -Wuninitialized only with -O or -On, n != 0.
  if test x${CFLAGS+set} = xset; then
Index: gdb/doc/gdbint.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.234
diff -c -p -r1.234 gdbint.texinfo
*** gdb/doc/gdbint.texinfo	4 Jan 2006 19:31:27 -0000	1.234
--- gdb/doc/gdbint.texinfo	18 Jan 2006 22:00:54 -0000
*************** switch (sched)
*** 5016,5021 ****
--- 5016,5030 ----
  @end smallexample

  @item -Wunused-function
+
+ @item -Wno-pointer-sign
+ In version 4.0, GCC began warning about pointer argument passing or
+ assignment even when the source and destination differed only in
+ signedness.  However, most @value{GDBN} code doesn't distinguish
+ carefully between @code{char} and @code{unsigned char}.  In early 2006
+ the @value{GDBN} developers decided correcting these warnings wasn't
+ worth the time it would take.
+
  @end table

  @emph{Pragmatics: Due to the way that @value{GDBN} is implemented most


             reply	other threads:[~2006-01-19  0:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-19  0:51 Jim Blandy [this message]
2006-01-19  4:31 ` Eli Zaretskii
2006-01-20 21:13 ` Daniel Jacobowitz
2006-01-20 21:27   ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f2776cb0601181651m5892f93wf756703b7e4b261a@mail.gmail.com \
    --to=jimb@red-bean.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox