From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24964 invoked by alias); 19 Jan 2006 00:51:46 -0000 Received: (qmail 24947 invoked by uid 22791); 19 Jan 2006 00:51:45 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.201) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 19 Jan 2006 00:51:43 +0000 Received: by zproxy.gmail.com with SMTP id m22so94460nzf for ; Wed, 18 Jan 2006 16:51:41 -0800 (PST) Received: by 10.36.139.12 with SMTP id m12mr7393412nzd; Wed, 18 Jan 2006 16:51:41 -0800 (PST) Received: by 10.37.2.42 with HTTP; Wed, 18 Jan 2006 16:51:41 -0800 (PST) Message-ID: <8f2776cb0601181651m5892f93wf756703b7e4b261a@mail.gmail.com> Date: Thu, 19 Jan 2006 00:51:00 -0000 From: Jim Blandy To: GDB Patches Subject: RFC: Disable pointer signedness warnings MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00241.txt.bz2 Just to push the group a little further towards making a decision, here's a patch: gdb/ChangeLog: 2006-01-18 Jim Blandy * configure.ac: Add -Wno-pointer-sign to list of build warnings. * configure: Regenerated. gdb/doc/ChangeLog: 2006-01-18 Jim Blandy * gdbint.texinfo (Coding): Add entry for -Wno-pointer-sign to list of warning flags. Index: gdb/configure.ac =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/configure.ac,v retrieving revision 1.25 diff -c -p -r1.25 configure.ac *** gdb/configure.ac 17 Dec 2005 22:33:59 -0000 1.25 --- gdb/configure.ac 18 Jan 2006 22:00:50 -0000 *************** AC_SUBST(TARGET_SYSTEM_ROOT_DEFINE) *** 1115,1121 **** # gdb/doc/gdbint.texinfo. build_warnings=3D"-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \ -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral \ ! -Wunused-label -Wunused-function" # GCC supports -Wuninitialized only with -O or -On, n !=3D 0. if test x${CFLAGS+set} =3D xset; then --- 1115,1121 ---- # gdb/doc/gdbint.texinfo. build_warnings=3D"-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \ -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral \ ! -Wunused-label -Wunused-function -Wno-pointer-sign" # GCC supports -Wuninitialized only with -O or -On, n !=3D 0. if test x${CFLAGS+set} =3D xset; then Index: gdb/doc/gdbint.texinfo =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v retrieving revision 1.234 diff -c -p -r1.234 gdbint.texinfo *** gdb/doc/gdbint.texinfo 4 Jan 2006 19:31:27 -0000 1.234 --- gdb/doc/gdbint.texinfo 18 Jan 2006 22:00:54 -0000 *************** switch (sched) *** 5016,5021 **** --- 5016,5030 ---- @end smallexample @item -Wunused-function + + @item -Wno-pointer-sign + In version 4.0, GCC began warning about pointer argument passing or + assignment even when the source and destination differed only in + signedness. However, most @value{GDBN} code doesn't distinguish + carefully between @code{char} and @code{unsigned char}. In early 2006 + the @value{GDBN} developers decided correcting these warnings wasn't + worth the time it would take. + @end table @emph{Pragmatics: Due to the way that @value{GDBN} is implemented most