From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: eliz@gnu.org
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Fix compiler warnings in osabi.c
Date: Sun, 15 Jan 2006 22:28:00 -0000 [thread overview]
Message-ID: <200601152228.k0FMSJwK005875@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <ur7795fzv.fsf@gnu.org> (message from Eli Zaretskii on Sun, 15 Jan 2006 23:38:12 +0200)
> Date: Sun, 15 Jan 2006 23:38:12 +0200
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Date: Sun, 15 Jan 2006 21:23:40 +0100 (CET)
> > From: Mark Kettenis <mark.kettenis@xs4all.nl>
> > CC: gdb-patches@sourceware.org
> >
> > It's a reasonable request, although I'd prefer to keep the literal as
> > is. The compiler should optimize away sizeof("FreeBSD") anyway. So I
> > committed the attached.
>
> The compiler will probably optimize, allright, but we now have the
> same string in two places in the sources, which creates a window,
> albeit a small one, for discrepancies.
Well, I think that's acceptable. This string is not going to change,
and both strings are right next to eachother.
Mark
prev parent reply other threads:[~2006-01-15 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 22:22 Mark Kettenis
2006-01-11 4:19 ` Daniel Jacobowitz
2006-01-11 4:22 ` Eli Zaretskii
2006-01-15 20:23 ` Mark Kettenis
2006-01-15 21:38 ` Eli Zaretskii
2006-01-15 22:28 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601152228.k0FMSJwK005875@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox