Re: [RFC] Fix compiler warnings in osabi.c

Mark Kettenis
2006-01-15T22:28:28Z

> Date: Sun, 15 Jan 2006 23:38:12 +0200
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Date: Sun, 15 Jan 2006 21:23:40 +0100 (CET)
> > From: Mark Kettenis <mark.kettenis@xs4all.nl>
> > CC: gdb-patches@sourceware.org
> >
> > It's a reasonable request, although I'd prefer to keep the literal as
> > is. The compiler should optimize away sizeof("FreeBSD") anyway. So I
> > committed the attached.
>
> The compiler will probably optimize, allright, but we now have the
> same string in two places in the sources, which creates a window,
> albeit a small one, for discrepancies.

Well, I think that's acceptable. This string is not going to change,
and both strings are right next to eachother.

Mark