Re: [RFC] Fix compiler warnings in osabi.c

Daniel Jacobowitz
2006-01-11T04:19:41Z

On Tue, Jan 10, 2006 at 11:22:23PM +0100, Mark Kettenis wrote:
> Another GCC 4 warning; e_ident[] is an array of unsigned chars. I
> think the most elegant way to solve this is to use memcmp instead of
> strcmp, since we're comparing a string to what may be random garbage,
> and not two strings.
>
> This one isn't quite so obvious, but if nobody objects, I'll commit
> this after a week.

Yes, looks right to me.

--
Daniel Jacobowitz
CodeSourcery