From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-42256-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4679 invoked by alias); 15 Jan 2006 22:28:28 -0000
Received: (qmail 4670 invoked by uid 22791); 15 Jan 2006 22:28:27 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 15 Jan 2006 22:28:25 +0000
Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) 	by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k0FMSKlo021326; 	Sun, 15 Jan 2006 23:28:20 +0100 (CET)
Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id k0FMSJbq003485; 	Sun, 15 Jan 2006 23:28:19 +0100 (CET)
Received: (from kettenis@localhost) 	by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id k0FMSJwK005875; 	Sun, 15 Jan 2006 23:28:19 +0100 (CET)
Date: Sun, 15 Jan 2006 22:28:00 -0000
Message-Id: <200601152228.k0FMSJwK005875@elgar.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: eliz@gnu.org
CC: gdb-patches@sourceware.org
In-reply-to: <ur7795fzv.fsf@gnu.org> (message from Eli Zaretskii on Sun, 15 	Jan 2006 23:38:12 +0200)
Subject: Re: [RFC] Fix compiler warnings in osabi.c
References: <200601102222.k0AMMNSq000979@elgar.sibelius.xs4all.nl> <uslrvqtqm.fsf@gnu.org> <200601152023.k0FKNeRn028527@elgar.sibelius.xs4all.nl> <ur7795fzv.fsf@gnu.org>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-01/txt/msg00189.txt.bz2

> Date: Sun, 15 Jan 2006 23:38:12 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Date: Sun, 15 Jan 2006 21:23:40 +0100 (CET)
> > From: Mark Kettenis <mark.kettenis@xs4all.nl>
> > CC: gdb-patches@sourceware.org
> > 
> > It's a reasonable request, although I'd prefer to keep the literal as
> > is.  The compiler should optimize away sizeof("FreeBSD") anyway.  So I
> > committed the attached.
> 
> The compiler will probably optimize, allright, but we now have the
> same string in two places in the sources, which creates a window,
> albeit a small one, for discrepancies.

Well, I think that's acceptable.  This string is not going to change,
and both strings are right next to eachother.

Mark