From: Eli Zaretskii <eliz@gnu.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Fix compiler warnings in osabi.c
Date: Wed, 11 Jan 2006 04:22:00 -0000 [thread overview]
Message-ID: <uslrvqtqm.fsf@gnu.org> (raw)
In-Reply-To: <200601102222.k0AMMNSq000979@elgar.sibelius.xs4all.nl> (message from Mark Kettenis on Tue, 10 Jan 2006 23:22:23 +0100 (CET))
> Date: Tue, 10 Jan 2006 23:22:23 +0100 (CET)
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
>
> - if (strcmp (&elf_elfheader (abfd)->e_ident[8], "FreeBSD") == 0)
> + if (memcmp (&elf_elfheader (abfd)->e_ident[8], "FreeBSD", 8) == 0)
I'm allergic to magic constants such as 8. Can we please make that
use sizeof("FreeBSD")? To avoid having two instances of "FreeBSD" in
the code, you could use a `const char []' variable with "FreeBSD" as
its value.
WDYT?
next prev parent reply other threads:[~2006-01-11 4:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 22:22 Mark Kettenis
2006-01-11 4:19 ` Daniel Jacobowitz
2006-01-11 4:22 ` Eli Zaretskii [this message]
2006-01-15 20:23 ` Mark Kettenis
2006-01-15 21:38 ` Eli Zaretskii
2006-01-15 22:28 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uslrvqtqm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox