From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-42178-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11054 invoked by alias); 11 Jan 2006 04:22:13 -0000
Received: (qmail 11043 invoked by uid 22791); 11 Jan 2006 04:22:12 -0000
X-Spam-Check-By: sourceware.org
Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 11 Jan 2006 04:22:11 +0000
Received: from HOME-C4E4A596F7 (IGLD-83-130-206-236.inter.net.il [83.130.206.236]) 	by nitzan.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id CKZ86895 (AUTH halo1); 	Wed, 11 Jan 2006 06:22:06 +0200 (IST)
Date: Wed, 11 Jan 2006 04:22:00 -0000
Message-Id: <uslrvqtqm.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
CC: gdb-patches@sourceware.org
In-reply-to: <200601102222.k0AMMNSq000979@elgar.sibelius.xs4all.nl> (message 	from Mark Kettenis on Tue, 10 Jan 2006 23:22:23 +0100 (CET))
Subject: Re: [RFC] Fix compiler warnings in osabi.c
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <200601102222.k0AMMNSq000979@elgar.sibelius.xs4all.nl>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-01/txt/msg00111.txt.bz2

> Date: Tue, 10 Jan 2006 23:22:23 +0100 (CET)
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> 
> -      if (strcmp (&elf_elfheader (abfd)->e_ident[8], "FreeBSD") == 0)
> +      if (memcmp (&elf_elfheader (abfd)->e_ident[8], "FreeBSD", 8) == 0)

I'm allergic to magic constants such as 8.  Can we please make that
use sizeof("FreeBSD")?  To avoid having two instances of "FreeBSD" in
the code, you could use a `const char []' variable with "FreeBSD" as
its value.

WDYT?