Re: [RFA] Turn on -Werror by default

[Daniel Jacobowitz <drow@false.org>]

On Sun, Jan 08, 2006 at 11:53:21PM +0100, Mark Kettenis wrote:
> Sorry, but I think we've waited long enough.  GCC 4 has been out for 9
> months now, so people have had plenty of time to fix issues with it.
> In fact, I think people have largely ignored its problems because we
> don't enable -Werror by default.  I bet enabling it, will make people
> actually fix the problems.

What version of GCC are you using?  The first of 189 GCC 4 warnings in
my builds comes from source.c (and is a little non-obvious to fix, I'm
working on it).  Exactly one warning is in Linux-specific code.

I definitely object if you're going to check in a patch that makes GDB
build nowhere by default.

> If you're talking about Linux builds that fall over with -Werror even
> with older GCC versions, then there is no real excuse.  GDB
> maintainers should have been compiling with -Werror for at least the
> past four years.

FYI, most of the -Werror problems in Linux builds with older compilers
are specifically fallout of fixes for the stupid GCC 4 warnings.  It
_used_ to build with -Werror until mass interface changes started
breaking it.

-- 
Daniel Jacobowitz
CodeSourcery