Re: [RFA] Turn on -Werror by default

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> Date: Sun, 15 Jan 2006 15:26:01 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> > Since we also seem to agree that the "warn for pointer argument
> > passing or assignment with different signedness" warning from GCC 4 is
> > mostly pedantry, how about the attached patch, which adds
> > -Wno-pointer-sign" to the mix.
> > 
> > I can add that bit first, and then when we've fixed the few remaining
> > warnings, we can enable -Werror.
> 
> I think we do need to fix the pointer sign warnings eventually, as a
> code cleanliness issue, so perhaps this is a good time to do it. 
> You've needled me enough this week that I'm actually rolling now :-)
> Give me a few days.

Heh ;-)

> BTW, if we were to go with your patch, wouldn't we would need to
> conditionalize the warning on an appropriate version of GCC?  Or is
> there pre-existing magic for this in $build_warnings?

Yes, there is.

> I'd gotten it into my head that there was no way to turn these off.
> Nice to be wrong about that.

It may very well be that -Wno-pointer-sign, wasn't there in GCC HEAD
when Andrew initially started "fixing" things.

Anyway, I'll keep this patch in my tree, and will bring it up again if
it turns out we need it.  I'll start nagging again in two weeks or so ;-).

Mark