Re: [RFA] Turn on -Werror by default

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> Date: Sun, 8 Jan 2006 17:25:47 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> On Sun, Jan 08, 2006 at 06:59:24PM +0100, Mark Kettenis wrote:
> > A while ago, we basically agreed that this would be a good thing to do
> > after the release.  I tried to steal the code form BFD, but that
> > didn't really fit in very well in our configure.ac.  Anyway, this adds
> > --enable-werror, defaulting to "yes", so to turn it off you'll
> > probably want to use --disable-werror.  This is similar to what BFD
> > does, so you can easily disable -Werror for the whole tree.  To
> > disable -Werror for GDB only, you can use
> > --enable-gdb-build-warnings=,-Wno-error.
> > 
> > ok?
> 
> Unless I've missed quite a lot, all Linux builds and targets are still
> noisy; can we add it but default to disabled for now?  Maybe that'll
> give someone (me?) incentive to finish the cleanup.

Sorry, but I think we've waited long enough.  GCC 4 has been out for 9
months now, so people have had plenty of time to fix issues with it.
In fact, I think people have largely ignored its problems because we
don't enable -Werror by default.  I bet enabling it, will make people
actually fix the problems.

If you're talking about Linux builds that fall over with -Werror even
with older GCC versions, then there is no real excuse.  GDB
maintainers should have been compiling with -Werror for at least the
past four years.

As a compromise, I'm willing to hold off checking in this patch (or
check it in with -enable-werror defaulting to "no"), if we set a fixed
date for enabling it not too far in the future.  The 1st of February
should give people enough time to sort out the last GCC 4 issues.

Mark