From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28507 invoked by alias); 8 Jan 2006 22:53:59 -0000 Received: (qmail 28496 invoked by uid 22791); 8 Jan 2006 22:53:58 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 08 Jan 2006 22:53:56 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k08MrLsS029553; Sun, 8 Jan 2006 23:53:21 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id k08MrLJm027559; Sun, 8 Jan 2006 23:53:21 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id k08MrLY1000252; Sun, 8 Jan 2006 23:53:21 +0100 (CET) Date: Sun, 08 Jan 2006 22:53:00 -0000 Message-Id: <200601082253.k08MrLY1000252@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: gdb-patches@sourceware.org In-reply-to: <20060108222546.GA4147@nevyn.them.org> (message from Daniel Jacobowitz on Sun, 8 Jan 2006 17:25:47 -0500) Subject: Re: [RFA] Turn on -Werror by default References: <200601081759.k08HxOxP007121@elgar.sibelius.xs4all.nl> <20060108222546.GA4147@nevyn.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00089.txt.bz2 > Date: Sun, 8 Jan 2006 17:25:47 -0500 > From: Daniel Jacobowitz > > On Sun, Jan 08, 2006 at 06:59:24PM +0100, Mark Kettenis wrote: > > A while ago, we basically agreed that this would be a good thing to do > > after the release. I tried to steal the code form BFD, but that > > didn't really fit in very well in our configure.ac. Anyway, this adds > > --enable-werror, defaulting to "yes", so to turn it off you'll > > probably want to use --disable-werror. This is similar to what BFD > > does, so you can easily disable -Werror for the whole tree. To > > disable -Werror for GDB only, you can use > > --enable-gdb-build-warnings=,-Wno-error. > > > > ok? > > Unless I've missed quite a lot, all Linux builds and targets are still > noisy; can we add it but default to disabled for now? Maybe that'll > give someone (me?) incentive to finish the cleanup. Sorry, but I think we've waited long enough. GCC 4 has been out for 9 months now, so people have had plenty of time to fix issues with it. In fact, I think people have largely ignored its problems because we don't enable -Werror by default. I bet enabling it, will make people actually fix the problems. If you're talking about Linux builds that fall over with -Werror even with older GCC versions, then there is no real excuse. GDB maintainers should have been compiling with -Werror for at least the past four years. As a compromise, I'm willing to hold off checking in this patch (or check it in with -enable-werror defaulting to "no"), if we set a fixed date for enabling it not too far in the future. The 1st of February should give people enough time to sort out the last GCC 4 issues. Mark