From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27593 invoked by alias); 15 Jan 2006 17:01:07 -0000 Received: (qmail 27580 invoked by uid 22791); 15 Jan 2006 17:01:06 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 15 Jan 2006 17:01:05 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EyBFX-0001Ww-3f; Sun, 15 Jan 2006 12:01:03 -0500 Date: Sun, 15 Jan 2006 17:01:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Turn on -Werror by default Message-ID: <20060115170103.GA5830@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <200601081759.k08HxOxP007121@elgar.sibelius.xs4all.nl> <20060108222546.GA4147@nevyn.them.org> <200601082253.k08MrLY1000252@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601082253.k08MrLY1000252@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00168.txt.bz2 On Sun, Jan 08, 2006 at 11:53:21PM +0100, Mark Kettenis wrote: > Sorry, but I think we've waited long enough. GCC 4 has been out for 9 > months now, so people have had plenty of time to fix issues with it. > In fact, I think people have largely ignored its problems because we > don't enable -Werror by default. I bet enabling it, will make people > actually fix the problems. What version of GCC are you using? The first of 189 GCC 4 warnings in my builds comes from source.c (and is a little non-obvious to fix, I'm working on it). Exactly one warning is in Linux-specific code. I definitely object if you're going to check in a patch that makes GDB build nowhere by default. > If you're talking about Linux builds that fall over with -Werror even > with older GCC versions, then there is no real excuse. GDB > maintainers should have been compiling with -Werror for at least the > past four years. FYI, most of the -Werror problems in Linux builds with older compilers are specifically fallout of fixes for the stupid GCC 4 warnings. It _used_ to build with -Werror until mass interface changes started breaking it. -- Daniel Jacobowitz CodeSourcery