From: Daniel Jacobowitz <drow@false.org>
To: Randolph Chung <randolph@tausq.org>
Cc: Jim Blandy <jimb@red-bean.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA/RFC] Support DW_OP_breg for tracepoints
Date: Mon, 14 Nov 2005 03:56:00 -0000 [thread overview]
Message-ID: <20051114022745.GA10422@nevyn.them.org> (raw)
In-Reply-To: <4377D0CB.2010304@tausq.org>
On Mon, Nov 14, 2005 at 07:48:27AM +0800, Randolph Chung wrote:
> >Why are you adding the offset twice? Is it just cut-and-paste from
> >the DW_OP_fbreg code? That looks wrong, too.
>
> Yes, copy and paste. I don't understand why it's added twice either :)
> Dan seems to think it's ok, but I'll wait a bit before I commit anything.
I assumed it was right by analogy to the existing frame base code.
Presumably I was just wrong the first time. Please fix both places.
Thanks, Jim.
> >This code should go in ax-gdb.[ch]. That has a translator from GDB
> >expressions to agent expressions; it would make sense to also have a
> >translator from Dwarf expressions to agent expressions.
Why is it any more logical to have dwarf code in ax-gdb.c than to have
agent code in dwarf2loc.c? In any case, it is a method of the symbol.
Please see struct symbol_ops.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-11-14 2:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-13 18:10 Randolph Chung
2005-11-13 18:11 ` Daniel Jacobowitz
2005-11-14 2:27 ` Jim Blandy
2005-11-14 3:41 ` Randolph Chung
2005-11-14 3:56 ` Daniel Jacobowitz [this message]
2005-11-14 15:57 ` Jim Blandy
2005-11-19 19:41 ` Randolph Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051114022745.GA10422@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@red-bean.com \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox