From: Jim Blandy <jimb@red-bean.com>
To: Randolph Chung <randolph@tausq.org>,
Jim Blandy <jimb@red-bean.com>,
gdb-patches@sources.redhat.com
Subject: Re: [RFA/RFC] Support DW_OP_breg for tracepoints
Date: Mon, 14 Nov 2005 15:57:00 -0000 [thread overview]
Message-ID: <8f2776cb0511132242x79de71e9y269de9a493576eb2@mail.gmail.com> (raw)
In-Reply-To: <20051114022745.GA10422@nevyn.them.org>
On 11/13/05, Daniel Jacobowitz <drow@false.org> wrote:
> > >This code should go in ax-gdb.[ch]. That has a translator from GDB
> > >expressions to agent expressions; it would make sense to also have a
> > >translator from Dwarf expressions to agent expressions.
>
> Why is it any more logical to have dwarf code in ax-gdb.c than to have
> agent code in dwarf2loc.c? In any case, it is a method of the symbol.
> Please see struct symbol_ops.
Yes, I'm not suggesting that we move locexpr_tracepoint_var_ref or
loclist_tracepoint_var_ref.
ax-general.c and ax.h are supposed to be very GDB-independent, and
depend only on the definition of the agent expression bytecode
language for their correctness. Everyplace else in GDB is supposed to
be as ignorant as possible of the details of agent expressions.
ax-gdb.c is supposed to be the meeting place where we handle the GDB
expression / agent expression relationship.
dwarf2_tracepoint_var_ref is a similar situation: it is where Dwarf
expressions and agent expressions meet. Other Dwarf code should stay
independent of the details of agent expressions, and other agent code
should stay independent of Dwarf. So maybe there should be a file
parallel to ax-gdb.c called ax-dwarf.c; but that seems like overkill.
My thought was to make ax-gdb.c the overall rendezvous where we get
down and dirty about the correspondence between agent expression
semantics and other little languages' semantics.
next prev parent reply other threads:[~2005-11-14 6:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-13 18:10 Randolph Chung
2005-11-13 18:11 ` Daniel Jacobowitz
2005-11-14 2:27 ` Jim Blandy
2005-11-14 3:41 ` Randolph Chung
2005-11-14 3:56 ` Daniel Jacobowitz
2005-11-14 15:57 ` Jim Blandy [this message]
2005-11-19 19:41 ` Randolph Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2776cb0511132242x79de71e9y269de9a493576eb2@mail.gmail.com \
--to=jimb@red-bean.com \
--cc=gdb-patches@sources.redhat.com \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox