Re: [RFA/RFC] Support DW_OP_breg for tracepoints

[Randolph Chung <randolph@tausq.org>]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

> I assumed it was right by analogy to the existing frame base code. 
> Presumably I was just wrong the first time.  Please fix both places.

this is what i finally checked in.

thanks
randolph


[-- Attachment #2: d.diff --]
[-- Type: text/x-patch, Size: 1553 bytes --]

2005-11-19  Randolph Chung  <tausq@debian.org>

	* dwarf2loc.c (dwarf2_tracepoint_var_ref): Remove extra add for
	DW_OP_fbreg.  Handle DW_OP_breg0 through DW_OP_breg31.  Print 
	DWARF opcode for unsupported case.

Index: dwarf2loc.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2loc.c,v
retrieving revision 1.31
diff -u -p -r1.31 dwarf2loc.c
--- dwarf2loc.c	14 Nov 2005 22:25:16 -0000	1.31
+++ dwarf2loc.c	19 Nov 2005 13:41:37 -0000
@@ -477,13 +477,30 @@ dwarf2_tracepoint_var_ref (struct symbol
       ax_const_l (ax, frame_offset);
       ax_simple (ax, aop_add);
 
-      ax_const_l (ax, frame_offset);
+      value->kind = axs_lvalue_memory;
+    }
+  else if (data[0] >= DW_OP_breg0
+	   && data[0] <= DW_OP_breg31)
+    {
+      unsigned int reg;
+      LONGEST offset;
+      gdb_byte *buf_end;
+
+      reg = data[0] - DW_OP_breg0;
+      buf_end = read_sleb128 (data + 1, data + size, &offset);
+      if (buf_end != data + size)
+	error (_("Unexpected opcode after DW_OP_breg%u for symbol \"%s\"."),
+	       reg, SYMBOL_PRINT_NAME (symbol));
+
+      ax_reg (ax, reg);
+      ax_const_l (ax, offset);
       ax_simple (ax, aop_add);
+
       value->kind = axs_lvalue_memory;
     }
   else
-    error (_("Unsupported DWARF opcode in the location of \"%s\"."),
-	   SYMBOL_PRINT_NAME (symbol));
+    error (_("Unsupported DWARF opcode 0x%x in the location of \"%s\"."),
+	   data[0], SYMBOL_PRINT_NAME (symbol));
 }
 \f
 /* Return the value of SYMBOL in FRAME using the DWARF-2 expression