From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11624 invoked by alias); 14 Nov 2005 02:27:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11607 invoked by uid 22791); 14 Nov 2005 02:27:48 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 14 Nov 2005 02:27:48 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EbU4P-0002iy-NL; Sun, 13 Nov 2005 21:27:45 -0500 Date: Mon, 14 Nov 2005 03:56:00 -0000 From: Daniel Jacobowitz To: Randolph Chung Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] Support DW_OP_breg for tracepoints Message-ID: <20051114022745.GA10422@nevyn.them.org> Mail-Followup-To: Randolph Chung , Jim Blandy , gdb-patches@sources.redhat.com References: <43775DDB.6020408@tausq.org> <8f2776cb0511131539j17ae5144n87b1aedab1fa420e@mail.gmail.com> <4377D0CB.2010304@tausq.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4377D0CB.2010304@tausq.org> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-11/txt/msg00182.txt.bz2 On Mon, Nov 14, 2005 at 07:48:27AM +0800, Randolph Chung wrote: > >Why are you adding the offset twice? Is it just cut-and-paste from > >the DW_OP_fbreg code? That looks wrong, too. > > Yes, copy and paste. I don't understand why it's added twice either :) > Dan seems to think it's ok, but I'll wait a bit before I commit anything. I assumed it was right by analogy to the existing frame base code. Presumably I was just wrong the first time. Please fix both places. Thanks, Jim. > >This code should go in ax-gdb.[ch]. That has a translator from GDB > >expressions to agent expressions; it would make sense to also have a > >translator from Dwarf expressions to agent expressions. Why is it any more logical to have dwarf code in ax-gdb.c than to have agent code in dwarf2loc.c? In any case, it is a method of the symbol. Please see struct symbol_ops. -- Daniel Jacobowitz CodeSourcery, LLC