From: Daniel Jacobowitz <drow@false.org>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: contribute Renesas M32C sim
Date: Sun, 09 Oct 2005 20:15:00 -0000 [thread overview]
Message-ID: <20051009201500.GD7107@nevyn.them.org> (raw)
In-Reply-To: <m3zmpl5a7a.fsf@alligator.red-bean.com>
There's a limit to how useful I can be reviewing sim patches, but I'll
try.
The most glaring omission is copyright notices. Not a single one.
Pretty much every file should have one. I assume the intention is to
assign this contribution to the FSF.
There seem to be a lot of too-long lines.
> + void
> + prefix (src_allowed, dest_allowed, index_bytewidth)
> + {
> + }
And what's that for?
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-10-09 20:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-07 20:46 Jim Blandy
2005-10-07 21:03 ` Daniel Jacobowitz
2005-10-09 0:29 ` Jim Blandy
2005-10-09 20:15 ` Daniel Jacobowitz [this message]
2005-10-12 18:21 ` Jim Blandy
[not found] ` <jimb@redhat.com>
2005-12-14 18:40 ` DJ Delorie
2005-12-15 0:01 ` Daniel Jacobowitz
2005-12-15 14:48 ` Jim Blandy
2005-12-15 16:18 ` Daniel Jacobowitz
2005-10-12 22:12 ` Jim Blandy
2006-01-23 2:03 ` Daniel Jacobowitz
2006-01-23 22:11 ` Jim Blandy
2005-10-15 12:06 ` Eli Zaretskii
2005-10-17 23:26 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051009201500.GD7107@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox