From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-41057-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 15933 invoked by alias); 9 Oct 2005 20:15:06 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15833 invoked by uid 22791); 9 Oct 2005 20:15:03 -0000
Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 09 Oct 2005 20:15:03 +0000
Received: from drow by nevyn.them.org with local (Exim 4.52)
	id 1EOhZU-00020K-9D; Sun, 09 Oct 2005 16:15:00 -0400
Date: Sun, 09 Oct 2005 20:15:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: contribute Renesas M32C sim
Message-ID: <20051009201500.GD7107@nevyn.them.org>
Mail-Followup-To: Jim Blandy <jimb@redhat.com>, gdb-patches@sourceware.org
References: <m3zmpl5a7a.fsf@alligator.red-bean.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3zmpl5a7a.fsf@alligator.red-bean.com>
User-Agent: Mutt/1.5.8i
X-SW-Source: 2005-10/txt/msg00079.txt.bz2

There's a limit to how useful I can be reviewing sim patches, but I'll
try.

The most glaring omission is copyright notices.  Not a single one. 
Pretty much every file should have one.  I assume the intention is to
assign this contribution to the FSF.

There seem to be a lot of too-long lines.

> + void
> + prefix (src_allowed, dest_allowed, index_bytewidth)
> + {
> + }

And what's that for?

-- 
Daniel Jacobowitz
CodeSourcery, LLC