Re: RFA: contribute Renesas M32C sim

Daniel Jacobowitz
2005-10-09T20:15:06Z

There's a limit to how useful I can be reviewing sim patches, but I'll
try.

The most glaring omission is copyright notices. Not a single one.
Pretty much every file should have one. I assume the intention is to
assign this contribution to the FSF.

There seem to be a lot of too-long lines.

> + void
> + prefix (src_allowed, dest_allowed, index_bytewidth)
> + {
> + }

And what's that for?

--
Daniel Jacobowitz
CodeSourcery, LLC