From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: RFA: contribute Renesas M32C sim
Date: Thu, 15 Dec 2005 00:01:00 -0000 [thread overview]
Message-ID: <20051213224722.GA14462@nevyn.them.org> (raw)
In-Reply-To: <200512132243.jBDMh6MN025311@greed.delorie.com>
On Tue, Dec 13, 2005 at 05:43:06PM -0500, DJ Delorie wrote:
>
> > >> + void
> > >> + prefix (src_allowed, dest_allowed, index_bytewidth)
> > >> + {
> > >> + }
> > >
> > > And what's that for?
> >
> > I don't know. I thought it was some sort of annotation for opc2c to
> > consume, but that doesn't seem to be so. I'll find out.
>
> I remember talking to Jim about this, but I don't see him answering in
> the mail archives, and since I was checking on the m32c/gdb status I
> figured I'd at least get this one answered.
>
> In short, that function exists so it can be called, it's the callers
> that are important at the moment.
>
> The callers act as documentation for what prefixes and indexes are
> permitted for each opcode. As I was going through the tedious process
> of implementing each opcode, I added all the calls to prefix() with
> the correct arguments. The function does nothing yet, but at some
> point in the future it may fault if prefixes are used where the real
> chip doesn't support them.
Then please add some useful information there, so that the next
reviewer through the code does not remove it :-)
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-12-13 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-07 20:46 Jim Blandy
2005-10-07 21:03 ` Daniel Jacobowitz
2005-10-09 0:29 ` Jim Blandy
2005-10-09 20:15 ` Daniel Jacobowitz
2005-10-12 18:21 ` Jim Blandy
[not found] ` <jimb@redhat.com>
2005-12-14 18:40 ` DJ Delorie
2005-12-15 0:01 ` Daniel Jacobowitz [this message]
2005-12-15 14:48 ` Jim Blandy
2005-12-15 16:18 ` Daniel Jacobowitz
2005-10-12 22:12 ` Jim Blandy
2006-01-23 2:03 ` Daniel Jacobowitz
2006-01-23 22:11 ` Jim Blandy
2005-10-15 12:06 ` Eli Zaretskii
2005-10-17 23:26 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051213224722.GA14462@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox