Patch to replace BFD_NEED_DECLARATION with AC_CHECK_DECLS

Patch to replace BFD_NEED_DECLARATION with AC_CHECK_DECLS

[Steve Ellcey]

This patch removes the use of BFD_NEED_DECLARATION from gdb/gdbserver
and replaces it with AC_CHECK_DECLS.  Once this checkin is done I intend
to remove the definition of BFD_NEED_DECLARATION from the bfd
subdirectory as it is no longer needed now that we are using newer
versions of autoconf that have AC_CHECK_DECLS.

There is still a use of BFD_NEED_DECLARATION in src/mmalloc but my
understanding is that mmalloc is no longer used and so that use can be
ignored.

The change was tested on IA64 Linux with no regressions.  I have not
done any gdb checkins before but I have done binutils changes and I do
have a gdb copyright assignment on file and write access to the src
repository so I can check this in myself if it is approved.

OK to checkin?

Steve Ellcey
sje@cup.hp.com


src/gdb/gdbserver/ChangeLog

2005-07-01  Steve Ellcey  <sje@cup.hp.com>

	* configure.ac (BFD_NEED_DECLARATION): Replace with AC_CHECK_DECLS.
	* configure: Regenerate.
	* config.in: Regenerate.
	* server.h (NEED_DECLARATION_STRERROR):
	Replace with !HAVE_DECL_STRERROR.

*** src.orig/gdb/gdbserver/configure.ac	Fri Jul  1 09:37:10 2005
--- src/gdb/gdbserver/configure.ac	Fri Jul  1 09:36:55 2005
*************** AC_CHECK_HEADERS(sgtty.h termio.h termio
*** 38,44 ****
  		 proc_service.h sys/procfs.h thread_db.h linux/elf.h dnl
  		 stdlib.h unistd.h)
  
! BFD_NEED_DECLARATION(strerror)
  
  AC_CHECK_TYPES(socklen_t, [], [],
  [#include <sys/types.h>
--- 38,44 ----
  		 proc_service.h sys/procfs.h thread_db.h linux/elf.h dnl
  		 stdlib.h unistd.h)
  
! AC_CHECK_DECLS(strerror)
  
  AC_CHECK_TYPES(socklen_t, [], [],
  [#include <sys/types.h>
*** src.orig/gdb/gdbserver/server.h	Fri Jul  1 09:37:15 2005
--- src/gdb/gdbserver/server.h	Fri Jul  1 09:36:55 2005
***************
*** 34,40 ****
  #include <string.h>
  #endif
  
! #ifdef NEED_DECLARATION_STRERROR
  #ifndef strerror
  extern char *strerror (int);	/* X3.159-1989  4.11.6.2 */
  #endif
--- 34,40 ----
  #include <string.h>
  #endif
  
! #if !HAVE_DECL_STRERROR
  #ifndef strerror
  extern char *strerror (int);	/* X3.159-1989  4.11.6.2 */
  #endif

Re: Patch to replace BFD_NEED_DECLARATION with AC_CHECK_DECLS

[Daniel Jacobowitz]

On Fri, Jul 01, 2005 at 09:48:56AM -0700, Steve Ellcey wrote:
> This patch removes the use of BFD_NEED_DECLARATION from gdb/gdbserver
> and replaces it with AC_CHECK_DECLS.  Once this checkin is done I intend
> to remove the definition of BFD_NEED_DECLARATION from the bfd
> subdirectory as it is no longer needed now that we are using newer
> versions of autoconf that have AC_CHECK_DECLS.
> 
> There is still a use of BFD_NEED_DECLARATION in src/mmalloc but my
> understanding is that mmalloc is no longer used and so that use can be
> ignored.
> 
> The change was tested on IA64 Linux with no regressions.  I have not
> done any gdb checkins before but I have done binutils changes and I do
> have a gdb copyright assignment on file and write access to the src
> repository so I can check this in myself if it is approved.
> 
> OK to checkin?

OK.  Please list yourself in write-after-approval in gdb/MAINTAINERS,
also.

-- 
Daniel Jacobowitz
CodeSourcery, LLC