From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5709 invoked by alias); 1 Jul 2005 16:49:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5672 invoked by uid 22791); 1 Jul 2005 16:48:59 -0000 Received: from palrel10.hp.com (HELO palrel10.hp.com) (156.153.255.245) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 01 Jul 2005 16:48:59 +0000 Received: from smtp1.ptp.hp.com (smtp1.ptp.hp.com [15.1.28.250]) by palrel10.hp.com (Postfix) with ESMTP id 69D7D12FB for ; Fri, 1 Jul 2005 09:48:57 -0700 (PDT) Received: from hpsje.cup.hp.com (hpsje.cup.hp.com [15.244.96.221]) by smtp1.ptp.hp.com (Postfix) with ESMTP id 32F911F2BED for ; Fri, 1 Jul 2005 16:48:57 +0000 (UTC) Received: (from sje@localhost) by hpsje.cup.hp.com (8.9.3 (PHNE_24419+JAGae58098)/8.7.3 TIS Messaging 5.0) id JAA14525 for gdb-patches@sourceware.org; Fri, 1 Jul 2005 09:48:56 -0700 (PDT) Date: Fri, 01 Jul 2005 16:49:00 -0000 From: Steve Ellcey Message-Id: <200507011648.JAA14525@hpsje.cup.hp.com> To: gdb-patches@sourceware.org Subject: Patch to replace BFD_NEED_DECLARATION with AC_CHECK_DECLS Reply-To: sje@cup.hp.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2005-07/txt/msg00006.txt.bz2 This patch removes the use of BFD_NEED_DECLARATION from gdb/gdbserver and replaces it with AC_CHECK_DECLS. Once this checkin is done I intend to remove the definition of BFD_NEED_DECLARATION from the bfd subdirectory as it is no longer needed now that we are using newer versions of autoconf that have AC_CHECK_DECLS. There is still a use of BFD_NEED_DECLARATION in src/mmalloc but my understanding is that mmalloc is no longer used and so that use can be ignored. The change was tested on IA64 Linux with no regressions. I have not done any gdb checkins before but I have done binutils changes and I do have a gdb copyright assignment on file and write access to the src repository so I can check this in myself if it is approved. OK to checkin? Steve Ellcey sje@cup.hp.com src/gdb/gdbserver/ChangeLog 2005-07-01 Steve Ellcey * configure.ac (BFD_NEED_DECLARATION): Replace with AC_CHECK_DECLS. * configure: Regenerate. * config.in: Regenerate. * server.h (NEED_DECLARATION_STRERROR): Replace with !HAVE_DECL_STRERROR. *** src.orig/gdb/gdbserver/configure.ac Fri Jul 1 09:37:10 2005 --- src/gdb/gdbserver/configure.ac Fri Jul 1 09:36:55 2005 *************** AC_CHECK_HEADERS(sgtty.h termio.h termio *** 38,44 **** proc_service.h sys/procfs.h thread_db.h linux/elf.h dnl stdlib.h unistd.h) ! BFD_NEED_DECLARATION(strerror) AC_CHECK_TYPES(socklen_t, [], [], [#include --- 38,44 ---- proc_service.h sys/procfs.h thread_db.h linux/elf.h dnl stdlib.h unistd.h) ! AC_CHECK_DECLS(strerror) AC_CHECK_TYPES(socklen_t, [], [], [#include *** src.orig/gdb/gdbserver/server.h Fri Jul 1 09:37:15 2005 --- src/gdb/gdbserver/server.h Fri Jul 1 09:36:55 2005 *************** *** 34,40 **** #include #endif ! #ifdef NEED_DECLARATION_STRERROR #ifndef strerror extern char *strerror (int); /* X3.159-1989 4.11.6.2 */ #endif --- 34,40 ---- #include #endif ! #if !HAVE_DECL_STRERROR #ifndef strerror extern char *strerror (int); /* X3.159-1989 4.11.6.2 */ #endif