Re: [PATCH] -data-list-changed-registers (Take 2)

[Daniel Jacobowitz <drow@false.org>]

On Tue, Jun 14, 2005 at 10:38:13AM +1200, Nick Roberts wrote:
>  > > From mi_cmd_data_list_register_values, I removed:
>  > > 
>  > > if (!target_has_registers)
>  > >   {
>  > >     mi_error_message = xstrprintf ("mi_cmd_data_list_register_values: No registers.");
>  > >     return MI_CMD_ERROR;
>  > >   }
>  > > 
>  > > Why do you think it should stay?
>  > 
>  > Cuz it was late and I wasn't paying a great deal of attention to your
>  > patch, once I figured out the mi_out_rewind problem.  In the interest
>  > of uniformity, let's remove it.  Could you (test and) commit the
>  > obvious patch?
> 
> Committed.

Thank you.

> 
> I get many failures on the testsuite, I'll try to move to a newer PC/kernel.
> mi-regs.exp seems OK though.

What failures, in particular?

> I would like to commit my changes to -var-update (2005-05-02) sometime.

Sorry, I need to take another look at them.  I will try to to find the
time.

> I have also removed a large number of annotations from my working copy.
> Andrew started this process, it would be nice if he can be involved but
> maybe thats not possible. There are a lot of changes to the following files:
> 
> gdb/ada-valprint.c
> gdb/annotate.c
> gdb/annotate.h
> gdb/blockframe.c
> gdb/breakpoint.c
> gdb/cp-valprint.c
> gdb/event-top.c
> gdb/frame.c
> gdb/infrun.c
> gdb/interps.c
> gdb/jv-valprint.c
> gdb/p-valprint.c
> gdb/printcmd.c
> gdb/stack.c
> gdb/utils.c
> gdb/valprint.c
> 
> Is anyone interested?  It would be good to do this now as a release doesn't
> seem to be imminent.

I can try to take a look at it.  I do not know much about the existing
annotations or how people use them; that's why it takes me a long time
to review any patches in this area.

-- 
Daniel Jacobowitz
CodeSourcery, LLC