From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23321 invoked by alias); 13 Jun 2005 22:42:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23310 invoked by uid 22791); 13 Jun 2005 22:42:17 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 13 Jun 2005 22:42:17 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DhxdH-0003ZE-Ub; Mon, 13 Jun 2005 18:42:16 -0400 Date: Mon, 13 Jun 2005 22:42:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] -data-list-changed-registers (Take 2) Message-ID: <20050613224215.GA13598@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <20050603191326.GA538@nevyn.them.org> <17056.56149.181259.513462@farnswood.snap.net.nz> <20050603223652.GA8203@nevyn.them.org> <17057.37727.725621.254956@farnswood.snap.net.nz> <17060.46539.131335.71422@farnswood.snap.net.nz> <17066.35303.833870.612064@farnswood.snap.net.nz> <20050613024022.GB9288@nevyn.them.org> <17069.4116.293354.462840@farnswood.snap.net.nz> <20050613134759.GA7102@nevyn.them.org> <17070.2773.135064.388886@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17070.2773.135064.388886@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00173.txt.bz2 On Tue, Jun 14, 2005 at 10:38:13AM +1200, Nick Roberts wrote: > > > From mi_cmd_data_list_register_values, I removed: > > > > > > if (!target_has_registers) > > > { > > > mi_error_message = xstrprintf ("mi_cmd_data_list_register_values: No registers."); > > > return MI_CMD_ERROR; > > > } > > > > > > Why do you think it should stay? > > > > Cuz it was late and I wasn't paying a great deal of attention to your > > patch, once I figured out the mi_out_rewind problem. In the interest > > of uniformity, let's remove it. Could you (test and) commit the > > obvious patch? > > Committed. Thank you. > > I get many failures on the testsuite, I'll try to move to a newer PC/kernel. > mi-regs.exp seems OK though. What failures, in particular? > I would like to commit my changes to -var-update (2005-05-02) sometime. Sorry, I need to take another look at them. I will try to to find the time. > I have also removed a large number of annotations from my working copy. > Andrew started this process, it would be nice if he can be involved but > maybe thats not possible. There are a lot of changes to the following files: > > gdb/ada-valprint.c > gdb/annotate.c > gdb/annotate.h > gdb/blockframe.c > gdb/breakpoint.c > gdb/cp-valprint.c > gdb/event-top.c > gdb/frame.c > gdb/infrun.c > gdb/interps.c > gdb/jv-valprint.c > gdb/p-valprint.c > gdb/printcmd.c > gdb/stack.c > gdb/utils.c > gdb/valprint.c > > Is anyone interested? It would be good to do this now as a release doesn't > seem to be imminent. I can try to take a look at it. I do not know much about the existing annotations or how people use them; that's why it takes me a long time to review any patches in this area. -- Daniel Jacobowitz CodeSourcery, LLC