Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, Christopher Faylor <me@cgf.cx>
Subject: Re: RFA: Use lrealpath instead of gdb_realpath
Date: Sun, 29 May 2005 19:28:00 -0000	[thread overview]
Message-ID: <20050529182726.GA28225@nevyn.them.org> (raw)
In-Reply-To: <umzqd9a5m.fsf@gnu.org>

On Sun, May 29, 2005 at 09:09:25PM +0300, Eli Zaretskii wrote:
> Disagree with what part? that backslashes might cause trouble or that
> D:\foo\bar/baz.c is ugly?

The former part.  Sure, the latter is ugly; that's a cosmetic bug in
whatever does the concatenation, as far as I'm concerned.  Or you can
pass the result back to lrealpath again and get a properly formatted
filename for the system.  Not a bad idea to do that anyway.  Or
to xfullpath, which might need some updated logic to support this.

> > It is not worth my time to continue arguing about filename handling;
> > consider the patch withdrawn indefinitely.
> 
> My suggestion is to fix lrealpath so that it (a) converts all
> backslashes to forward slashes, (b) does NOT downcase the result, and
> (c) returns its argument unaltered if the absolute file name does not
> point to an existing file.  When modified like that, I think lrealpath
> will work the same on all platforms; as for strdup vs xstrdup part, we
> will need to change the code in GDB to test for a NULL return value.
> 
> If this alternative is acceptable to other maintainers, I can
> volunteer to produce a patch along these lines.

If you want to do the work, I invite you to talk to the Windows
maintainers about it; which would mean Chris and Danny Smith, who I do
not believe reads this list.  I doubt they'd be interested in (a),
since Chris obviously disagrees with you about backslashes.  But you
might be able to reach agreements on (b) and (c).

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  parent reply	other threads:[~2005-05-29 18:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-28 23:59 Daniel Jacobowitz
2005-05-29  1:59 ` Christopher Faylor
2005-05-29 14:21 ` Eli Zaretskii
2005-05-29 14:23   ` Daniel Jacobowitz
2005-05-29 17:49     ` Christopher Faylor
2005-05-29 18:22     ` Eli Zaretskii
2005-05-29 18:27       ` Christopher Faylor
2005-05-30 16:54         ` Eli Zaretskii
2005-05-29 19:28       ` Daniel Jacobowitz [this message]
2005-05-29 20:16         ` Christopher Faylor
2005-05-30 15:14           ` Christopher Faylor
2005-05-30 18:32           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050529182726.GA28225@nevyn.them.org \
    --to=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=me@cgf.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox