Re: RFA: Use lrealpath instead of gdb_realpath

Daniel Jacobowitz
2005-05-29T18:27:31Z

On Sun, May 29, 2005 at 09:09:25PM +0300, Eli Zaretskii wrote:
> Disagree with what part? that backslashes might cause trouble or that
> D:\foo\bar/baz.c is ugly?

The former part. Sure, the latter is ugly; that's a cosmetic bug in
whatever does the concatenation, as far as I'm concerned. Or you can
pass the result back to lrealpath again and get a properly formatted
filename for the system. Not a bad idea to do that anyway. Or
to xfullpath, which might need some updated logic to support this.

> > It is not worth my time to continue arguing about filename handling;
> > consider the patch withdrawn indefinitely.
>
> My suggestion is to fix lrealpath so that it (a) converts all
> backslashes to forward slashes, (b) does NOT downcase the result, and
> (c) returns its argument unaltered if the absolute file name does not
> point to an existing file. When modified like that, I think lrealpath
> will work the same on all platforms; as for strdup vs xstrdup part, we
> will need to change the code in GDB to test for a NULL return value.
>
> If this alternative is acceptable to other maintainers, I can
> volunteer to produce a patch along these lines.

If you want to do the work, I invite you to talk to the Windows
maintainers about it; which would mean Chris and Danny Smith, who I do
not believe reads this list. I doubt they'd be interested in (a),
since Chris obviously disagrees with you about backslashes. But you
might be able to reach agreements on (b) and (c).

--
Daniel Jacobowitz
CodeSourcery, LLC