From: Christopher Faylor <me@cgf.cx>
To: gdb-patches@sourceware.org
Subject: Re: RFA: Use lrealpath instead of gdb_realpath
Date: Sun, 29 May 2005 17:49:00 -0000 [thread overview]
Message-ID: <20050529162204.GA11936@trixie.casa.cgf.cx> (raw)
In-Reply-To: <20050529142112.GB23858@nevyn.them.org>
On Sun, May 29, 2005 at 10:21:12AM -0400, Daniel Jacobowitz wrote:
>>Let me explain my concerns about using lrealpath in its current shape:
>>
>> . The Windows code in lrealpath converts all forward slashes to
>> backslashes, which I think is a bad idea. By contrast, the current
>> gdb_realpath would leave existing forward slashes alone. That is
>> an incompatible change, and my gut feeling is that we should not
>> risk it. On top of that, I think we always use '/' to generate
>> file names, so with this change we will produce ugly file names
>> like D:\foo\bar/baz.c.
>
>The Windows maintainers disagree with you. So, for the record, do I.
Yes. I have to say that I can't recall a situation where slashes and
backslashes make a difference but, if there was going to be a problem,
it seems like the problem would be with the use of slashes.
>It is not worth my time to continue arguing about filename handling;
>consider the patch withdrawn indefinitely.
That is a shame. Having two similar functions really doesn't make a
lot of sense to me.
cgf
next prev parent reply other threads:[~2005-05-29 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-28 23:59 Daniel Jacobowitz
2005-05-29 1:59 ` Christopher Faylor
2005-05-29 14:21 ` Eli Zaretskii
2005-05-29 14:23 ` Daniel Jacobowitz
2005-05-29 17:49 ` Christopher Faylor [this message]
2005-05-29 18:22 ` Eli Zaretskii
2005-05-29 18:27 ` Christopher Faylor
2005-05-30 16:54 ` Eli Zaretskii
2005-05-29 19:28 ` Daniel Jacobowitz
2005-05-29 20:16 ` Christopher Faylor
2005-05-30 15:14 ` Christopher Faylor
2005-05-30 18:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050529162204.GA11936@trixie.casa.cgf.cx \
--to=me@cgf.cx \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox