From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24748 invoked by alias); 29 May 2005 16:22:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24711 invoked by uid 22791); 29 May 2005 16:22:06 -0000 Received: from c-66-30-17-189.hsd1.ma.comcast.net (HELO cgf.cx) (66.30.17.189) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 29 May 2005 16:22:06 +0000 Received: by cgf.cx (Postfix, from userid 201) id 901F213CA7E; Sun, 29 May 2005 12:22:04 -0400 (EDT) Date: Sun, 29 May 2005 17:49:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org Subject: Re: RFA: Use lrealpath instead of gdb_realpath Message-ID: <20050529162204.GA11936@trixie.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org References: <20050528234233.GA3440@nevyn.them.org> <20050529142112.GB23858@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050529142112.GB23858@nevyn.them.org> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00621.txt.bz2 On Sun, May 29, 2005 at 10:21:12AM -0400, Daniel Jacobowitz wrote: >>Let me explain my concerns about using lrealpath in its current shape: >> >> . The Windows code in lrealpath converts all forward slashes to >> backslashes, which I think is a bad idea. By contrast, the current >> gdb_realpath would leave existing forward slashes alone. That is >> an incompatible change, and my gut feeling is that we should not >> risk it. On top of that, I think we always use '/' to generate >> file names, so with this change we will produce ugly file names >> like D:\foo\bar/baz.c. > >The Windows maintainers disagree with you. So, for the record, do I. Yes. I have to say that I can't recall a situation where slashes and backslashes make a difference but, if there was going to be a problem, it seems like the problem would be with the use of slashes. >It is not worth my time to continue arguing about filename handling; >consider the patch withdrawn indefinitely. That is a shame. Having two similar functions really doesn't make a lot of sense to me. cgf