From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20697 invoked by alias); 29 May 2005 18:27:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20676 invoked by uid 22791); 29 May 2005 18:27:27 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 29 May 2005 18:27:27 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DcSVS-0007X8-9g; Sun, 29 May 2005 14:27:26 -0400 Date: Sun, 29 May 2005 19:28:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: gdb-patches@sourceware.org, Christopher Faylor Subject: Re: RFA: Use lrealpath instead of gdb_realpath Message-ID: <20050529182726.GA28225@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , gdb-patches@sourceware.org, Christopher Faylor References: <20050528234233.GA3440@nevyn.them.org> <20050529142112.GB23858@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00627.txt.bz2 On Sun, May 29, 2005 at 09:09:25PM +0300, Eli Zaretskii wrote: > Disagree with what part? that backslashes might cause trouble or that > D:\foo\bar/baz.c is ugly? The former part. Sure, the latter is ugly; that's a cosmetic bug in whatever does the concatenation, as far as I'm concerned. Or you can pass the result back to lrealpath again and get a properly formatted filename for the system. Not a bad idea to do that anyway. Or to xfullpath, which might need some updated logic to support this. > > It is not worth my time to continue arguing about filename handling; > > consider the patch withdrawn indefinitely. > > My suggestion is to fix lrealpath so that it (a) converts all > backslashes to forward slashes, (b) does NOT downcase the result, and > (c) returns its argument unaltered if the absolute file name does not > point to an existing file. When modified like that, I think lrealpath > will work the same on all platforms; as for strdup vs xstrdup part, we > will need to change the code in GDB to test for a NULL return value. > > If this alternative is acceptable to other maintainers, I can > volunteer to produce a patch along these lines. If you want to do the work, I invite you to talk to the Windows maintainers about it; which would mean Chris and Danny Smith, who I do not believe reads this list. I doubt they'd be interested in (a), since Chris obviously disagrees with you about backslashes. But you might be able to reach agreements on (b) and (c). -- Daniel Jacobowitz CodeSourcery, LLC