Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [patch] seperate HP aCC compiler_info into Major, Minor, and Extension
@ 2005-04-08 22:23 Paul Gilliam
  2005-04-14 19:16 ` Daniel Jacobowitz
  0 siblings, 1 reply; 5+ messages in thread
From: Paul Gilliam @ 2005-04-08 22:23 UTC (permalink / raw)
  To: gdb-patches

This patch seperates the compiler info string for the HP aCC compiler into it's components.
The old value for version A.01.21  was hpacc-010121; the new value would be hpacc-01-01-21.
This is consistant with the why GCC is handled.

-=# Paul #=-

---
2005-04-08  Paul Gilliam  <pgilliam@us.ibm.com>

	* lib/compiler.c: Divide HP aCC 'compiler_info' into components.
	* lib/compiler.cc: Likewise.

Index: lib/compiler.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/compiler.c,v
retrieving revision 1.10
diff -c -3 -p -r1.10 compiler.c
*** lib/compiler.c	7 Mar 2005 18:57:57 -0000	1.10
--- lib/compiler.c	8 Apr 2005 22:14:43 -0000
*************** set compiler_info [join {hpcc __HP_cc} -
*** 62,68 ****
  #endif
  
  #if defined (__HP_aCC)
! set compiler_info [join {hpacc __HP_aCC} -]
  #endif
  
  #if defined (__xlc__)
--- 62,68 ----
  #endif
  
  #if defined (__HP_aCC)
! set need_a_set [eval {regexp {(..)(..)(..)} __HP_aCC dontcare mm nn xx;set compiler_info "hpacc-$mm-$nn-$xx"}]
  #endif
  
  #if defined (__xlc__)
Index: lib/compiler.cc
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/compiler.cc,v
retrieving revision 1.12
diff -c -3 -p -r1.12 compiler.cc
*** lib/compiler.cc	7 Mar 2005 18:57:57 -0000	1.12
--- lib/compiler.cc	8 Apr 2005 22:14:43 -0000
*************** set compiler_info [join {hpcc __HP_cc} -
*** 50,56 ****
  #endif
  
  #if defined (__HP_aCC)
! set compiler_info [join {hpacc __HP_aCC} -]
  #endif
  
  #if defined (__xlc__)
--- 50,56 ----
  #endif
  
  #if defined (__HP_aCC)
! set need_a_set [eval {regexp {(..)(..)(..)} __HP_aCC dontcare mm nn xx;set compiler_info "hpacc-$mm-$nn-$xx"}]
  #endif
  
  #if defined (__xlc__)
 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch] seperate HP aCC compiler_info into Major, Minor, and Extension
  2005-04-08 22:23 [patch] seperate HP aCC compiler_info into Major, Minor, and Extension Paul Gilliam
@ 2005-04-14 19:16 ` Daniel Jacobowitz
  2005-04-15 19:35   ` Paul Gilliam
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Jacobowitz @ 2005-04-14 19:16 UTC (permalink / raw)
  To: Paul Gilliam; +Cc: gdb-patches

On Fri, Apr 08, 2005 at 02:21:07PM -0800, Paul Gilliam wrote:
> This patch seperates the compiler info string for the HP aCC compiler into it's components.
> The old value for version A.01.21  was hpacc-010121; the new value would be hpacc-01-01-21.
> This is consistant with the why GCC is handled.
> 
> -=# Paul #=-
> 
> ---
> 2005-04-08  Paul Gilliam  <pgilliam@us.ibm.com>
> 
> 	* lib/compiler.c: Divide HP aCC 'compiler_info' into components.
> 	* lib/compiler.cc: Likewise.

Not OK I'm afraid.  I tried an aCC installation I had handy:

bash-2.05b$ aCC --version
aCC: HP ANSI C++ B3910B A.03.45

set compiler_info [join {hpacc 34500 } -]

That's not going to match your regexp.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch] seperate HP aCC compiler_info into Major, Minor, and Extension
  2005-04-14 19:16 ` Daniel Jacobowitz
@ 2005-04-15 19:35   ` Paul Gilliam
  2005-04-15 19:36     ` Daniel Jacobowitz
  0 siblings, 1 reply; 5+ messages in thread
From: Paul Gilliam @ 2005-04-15 19:35 UTC (permalink / raw)
  To: gdb-patches; +Cc: Daniel Jacobowitz

On Thursday 14 April 2005 12:16, Daniel Jacobowitz wrote:
> On Fri, Apr 08, 2005 at 02:21:07PM -0800, Paul Gilliam wrote:
> > This patch seperates the compiler info string for the HP aCC compiler into it's components.
> > The old value for version A.01.21  was hpacc-010121; the new value would be hpacc-01-01-21.
> > This is consistant with the why GCC is handled.
> > 
> > -=# Paul #=-
> > 
> > ---
> > 2005-04-08  Paul Gilliam  <pgilliam@us.ibm.com>
> > 
> > 	* lib/compiler.c: Divide HP aCC 'compiler_info' into components.
> > 	* lib/compiler.cc: Likewise.
> 
> Not OK I'm afraid.  I tried an aCC installation I had handy:
> 
> bash-2.05b$ aCC --version
> aCC: HP ANSI C++ B3910B A.03.45
> 
> set compiler_info [join {hpacc 34500 } -]
> 
> That's not going to match your regexp.
> 

From the doc I read on the net somewhere, that version info
should be translated into 'hpacc 010345'.

And we all know, the net nevers is wrong.  8-(

should it be changed to:
set need_a_set [eval {regexp {1(..)(..)(..)} [expr __HP_aCC + 1000000] dontcare nn xx mm;set compiler_info "hpacc-$mm-$nn-$xx"}]

or to:
set need_a_set [eval {regexp {1(..)(..)(..)..} [expr __HP_aCC + 100000000] dontcare mm nn xx;set compiler_info "hpacc-$mm-$nn-$xx"}]

or just forget the whole thing?  Maybe this is more futzing around than it's worth.
(But I do like it when things are consistant.)

-=# Paul #=-




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch] seperate HP aCC compiler_info into Major, Minor, and Extension
  2005-04-15 19:35   ` Paul Gilliam
@ 2005-04-15 19:36     ` Daniel Jacobowitz
  2005-04-15 19:42       ` Paul Gilliam
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Jacobowitz @ 2005-04-15 19:36 UTC (permalink / raw)
  To: Paul Gilliam; +Cc: gdb-patches

On Fri, Apr 15, 2005 at 11:34:14AM -0800, Paul Gilliam wrote:
> or just forget the whole thing?  Maybe this is more futzing around than it's worth.
> (But I do like it when things are consistant.)

I'd rather drop it.  If you're looking at this number, then you know
you want a version of the HP aCC compiler already; so let's leave it in
the aCC format.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch] seperate HP aCC compiler_info into Major, Minor, and Extension
  2005-04-15 19:36     ` Daniel Jacobowitz
@ 2005-04-15 19:42       ` Paul Gilliam
  0 siblings, 0 replies; 5+ messages in thread
From: Paul Gilliam @ 2005-04-15 19:42 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: gdb-patches

On Friday 15 April 2005 12:36, Daniel Jacobowitz wrote:
> On Fri, Apr 15, 2005 at 11:34:14AM -0800, Paul Gilliam wrote:
> > or just forget the whole thing?  Maybe this is more futzing around than it's worth.
> > (But I do like it when things are consistant.)
> 
> I'd rather drop it.  If you're looking at this number, then you know
> you want a version of the HP aCC compiler already; so let's leave it in
> the aCC format.
> 

Well, it was fun while it lasted.  8-)  For me, being a ppc64 person, it was academic anyway.

Sorry for any wasted time/effort.

-=# Paul #=-


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2005-04-15 19:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-08 22:23 [patch] seperate HP aCC compiler_info into Major, Minor, and Extension Paul Gilliam
2005-04-14 19:16 ` Daniel Jacobowitz
2005-04-15 19:35   ` Paul Gilliam
2005-04-15 19:36     ` Daniel Jacobowitz
2005-04-15 19:42       ` Paul Gilliam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox