Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Maciej W. Rozycki" <macro@mips.com>,
	gdb-patches@sources.redhat.com, macro@linux-mips.org
Subject: Re: Support for "break *ADDRESS thread THREADNO"
Date: Wed, 13 Apr 2005 17:41:00 -0000	[thread overview]
Message-ID: <20050413174126.GA31963@nevyn.them.org> (raw)
In-Reply-To: <01c5404e$Blat.v2.4$da8679c0@zahav.net.il>

On Wed, Apr 13, 2005 at 08:32:04PM +0300, Eli Zaretskii wrote:
> > Date: Wed, 13 Apr 2005 11:35:29 +0100 (BST)
> > From: "Maciej W. Rozycki" <macro@mips.com>
> > cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sources.redhat.com, 
> >     "Maciej W. Rozycki" <macro@linux-mips.org>
> > 
> >  I think the actual problem is the expression parser cannot be told to 
> > stop successfully on an unparseable token as long as the expression 
> > collected so far is valid and let the caller deal with that.
> 
> We could detect and remove the "thread NUMBER" part from the string we
> pass to the parser, couldn't we?

I have the feeling this is going to be pretty tricky to get right.  For
instance, it can come before or after the "if" clause.  (Well, I
thought it could; the manual only says before.)  So if it comes before
then you have a line like:

  break *EXPRESSION thread 5 if EXPRESSION

Suppose one of those expressions includes:
  strcmp ("thread 5", my_thread_name)

Picking out the thread number would require at least lexing, and
possibly parsing.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


      reply	other threads:[~2005-04-13 17:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-12 15:54 Maciej W. Rozycki
2005-04-12 18:13 ` Daniel Jacobowitz
2005-04-12 18:24   ` Maciej W. Rozycki
2005-04-12 18:51   ` Eli Zaretskii
2005-04-12 18:55     ` Daniel Jacobowitz
2005-04-12 19:05       ` Eli Zaretskii
2005-04-12 19:17         ` Stan Shebs
2005-04-12 19:21           ` Daniel Jacobowitz
2005-04-12 19:22         ` Daniel Jacobowitz
2005-04-13 10:36       ` Maciej W. Rozycki
2005-04-13 12:09         ` Daniel Jacobowitz
2005-04-13 16:05           ` Maciej W. Rozycki
2005-04-13 17:37         ` Eli Zaretskii
2005-04-13 17:41           ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050413174126.GA31963@nevyn.them.org \
    --to=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=macro@linux-mips.org \
    --cc=macro@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox