Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Maciej W. Rozycki" <macro@mips.com>, gdb-patches@sources.redhat.com
Subject: Re: Support for "break *ADDRESS thread THREADNO"
Date: Tue, 12 Apr 2005 18:55:00 -0000	[thread overview]
Message-ID: <20050412185549.GA9715@nevyn.them.org> (raw)
In-Reply-To: <01c53f90$Blat.v2.4$17427900@zahav.net.il>

On Tue, Apr 12, 2005 at 09:46:31PM +0300, Eli Zaretskii wrote:
> In addition to the above, I don't like the idea of supporting a
> general feature in language-specific files.  That seems wrong.
> 
> Why was it done like this? because "*ADDRESS" is interpreted as an
> expression in the current language, or is there some other reason?

I assume so.  It is parsed as an expression, not just an address; for
instance "break *thread" would actually work if thread is a pointer to
a function.

There's already common code for this, that's where most of the 'thread
THREADNO' support is.  I think it's in linespec.c somewhere, but it
might be in breakpoint.c.  It seems to need a little extra help from
the language... we need to know that a 'thread NUMBER' suffix is not
part of the expression.

TBH, the mechanism is fragile; I can't think of a more robust way but
there must be one.  Right now if and thread are handled similarly.  But
if separates two expressions, whereas thread can only be followed by a
thread number.  Perhaps that can be used to simplify.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  reply	other threads:[~2005-04-12 18:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-12 15:54 Maciej W. Rozycki
2005-04-12 18:13 ` Daniel Jacobowitz
2005-04-12 18:24   ` Maciej W. Rozycki
2005-04-12 18:51   ` Eli Zaretskii
2005-04-12 18:55     ` Daniel Jacobowitz [this message]
2005-04-12 19:05       ` Eli Zaretskii
2005-04-12 19:17         ` Stan Shebs
2005-04-12 19:21           ` Daniel Jacobowitz
2005-04-12 19:22         ` Daniel Jacobowitz
2005-04-13 10:36       ` Maciej W. Rozycki
2005-04-13 12:09         ` Daniel Jacobowitz
2005-04-13 16:05           ` Maciej W. Rozycki
2005-04-13 17:37         ` Eli Zaretskii
2005-04-13 17:41           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050412185549.GA9715@nevyn.them.org \
    --to=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=macro@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox