Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@gnu.org>
To: "Maciej W. Rozycki" <macro@mips.com>, gdb-patches@sources.redhat.com
Subject: Re: Support for "break *ADDRESS thread THREADNO"
Date: Tue, 12 Apr 2005 18:51:00 -0000	[thread overview]
Message-ID: <01c53f90$Blat.v2.4$17427900@zahav.net.il> (raw)
In-Reply-To: <20050412181334.GA2560@nevyn.them.org> (message from Daniel Jacobowitz on Tue, 12 Apr 2005 14:13:34 -0400)

> Date: Tue, 12 Apr 2005 14:13:34 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sources.redhat.com
> 
> > 2005-04-12  Maciej W. Rozycki  <macro@mips.com>
> > 
> > 	* ada-lex.l: Support the "thread THREADNO" clause with breakpoints
> > 	at an address.
> > 	* c-exp.y (yylex): Likewise.
> > 	* f-exp.y (yylex): Likewise.
> > 	* jv-exp.y (yylex): Likewise.
> > 	* m2-exp.y (yylex): Likewise.
> > 	* objc-exp.y (yylex): Likewise.
> > 	* p-exp.y (yylex): Likewise.
> > 
> >  This has been verified for the HEAD version with the test suite for the 
> > i386-linux-gnu system natively with no regressions.  Please consider.
> 
> No, sorry.  Consider:
> 
> (gdb) p *thread
> No symbol table is loaded.  Use the "file" command.
> 
> After your patch:
> 
> (gdb) b *thread
> A parse error in expression, near `thread'.
> 
> We can get away with this for 'if', because 'if' is a keyword in just
> about every language GDB supports, and an unlikely name for a variable.
> That's not going to fly for 'thread', however.

In addition to the above, I don't like the idea of supporting a
general feature in language-specific files.  That seems wrong.

Why was it done like this? because "*ADDRESS" is interpreted as an
expression in the current language, or is there some other reason?


  parent reply	other threads:[~2005-04-12 18:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-12 15:54 Maciej W. Rozycki
2005-04-12 18:13 ` Daniel Jacobowitz
2005-04-12 18:24   ` Maciej W. Rozycki
2005-04-12 18:51   ` Eli Zaretskii [this message]
2005-04-12 18:55     ` Daniel Jacobowitz
2005-04-12 19:05       ` Eli Zaretskii
2005-04-12 19:17         ` Stan Shebs
2005-04-12 19:21           ` Daniel Jacobowitz
2005-04-12 19:22         ` Daniel Jacobowitz
2005-04-13 10:36       ` Maciej W. Rozycki
2005-04-13 12:09         ` Daniel Jacobowitz
2005-04-13 16:05           ` Maciej W. Rozycki
2005-04-13 17:37         ` Eli Zaretskii
2005-04-13 17:41           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='01c53f90$Blat.v2.4$17427900@zahav.net.il' \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=macro@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox