From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12023 invoked by alias); 12 Apr 2005 18:51:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11936 invoked from network); 12 Apr 2005 18:51:44 -0000 Received: from unknown (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org with SMTP; 12 Apr 2005 18:51:44 -0000 Received: from zaretski (IGLD-84-228-140-110.inter.net.il [84.228.140.110]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id AYX78109 (AUTH halo1); Tue, 12 Apr 2005 21:50:58 +0300 (IDT) Date: Tue, 12 Apr 2005 18:51:00 -0000 From: "Eli Zaretskii" To: "Maciej W. Rozycki" , gdb-patches@sources.redhat.com Message-ID: <01c53f90$Blat.v2.4$17427900@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 In-reply-to: <20050412181334.GA2560@nevyn.them.org> (message from Daniel Jacobowitz on Tue, 12 Apr 2005 14:13:34 -0400) Subject: Re: Support for "break *ADDRESS thread THREADNO" Reply-to: Eli Zaretskii References: <20050412181334.GA2560@nevyn.them.org> X-SW-Source: 2005-04/txt/msg00097.txt.bz2 > Date: Tue, 12 Apr 2005 14:13:34 -0400 > From: Daniel Jacobowitz > Cc: gdb-patches@sources.redhat.com > > > 2005-04-12 Maciej W. Rozycki > > > > * ada-lex.l: Support the "thread THREADNO" clause with breakpoints > > at an address. > > * c-exp.y (yylex): Likewise. > > * f-exp.y (yylex): Likewise. > > * jv-exp.y (yylex): Likewise. > > * m2-exp.y (yylex): Likewise. > > * objc-exp.y (yylex): Likewise. > > * p-exp.y (yylex): Likewise. > > > > This has been verified for the HEAD version with the test suite for the > > i386-linux-gnu system natively with no regressions. Please consider. > > No, sorry. Consider: > > (gdb) p *thread > No symbol table is loaded. Use the "file" command. > > After your patch: > > (gdb) b *thread > A parse error in expression, near `thread'. > > We can get away with this for 'if', because 'if' is a keyword in just > about every language GDB supports, and an unlikely name for a variable. > That's not going to fly for 'thread', however. In addition to the above, I don't like the idea of supporting a general feature in language-specific files. That seems wrong. Why was it done like this? because "*ADDRESS" is interpreted as an expression in the current language, or is there some other reason?