From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23813 invoked by alias); 13 Apr 2005 17:41:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23616 invoked from network); 13 Apr 2005 17:41:29 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 13 Apr 2005 17:41:29 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DLlri-0008Ll-FT; Wed, 13 Apr 2005 13:41:26 -0400 Date: Wed, 13 Apr 2005 17:41:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: "Maciej W. Rozycki" , gdb-patches@sources.redhat.com, macro@linux-mips.org Subject: Re: Support for "break *ADDRESS thread THREADNO" Message-ID: <20050413174126.GA31963@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , "Maciej W. Rozycki" , gdb-patches@sources.redhat.com, macro@linux-mips.org References: <20050412181334.GA2560@nevyn.them.org> <01c53f90$Blat.v2.4$17427900@zahav.net.il> <20050412185549.GA9715@nevyn.them.org> <01c5404e$Blat.v2.4$da8679c0@zahav.net.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01c5404e$Blat.v2.4$da8679c0@zahav.net.il> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00117.txt.bz2 On Wed, Apr 13, 2005 at 08:32:04PM +0300, Eli Zaretskii wrote: > > Date: Wed, 13 Apr 2005 11:35:29 +0100 (BST) > > From: "Maciej W. Rozycki" > > cc: Eli Zaretskii , gdb-patches@sources.redhat.com, > > "Maciej W. Rozycki" > > > > I think the actual problem is the expression parser cannot be told to > > stop successfully on an unparseable token as long as the expression > > collected so far is valid and let the caller deal with that. > > We could detect and remove the "thread NUMBER" part from the string we > pass to the parser, couldn't we? I have the feeling this is going to be pretty tricky to get right. For instance, it can come before or after the "if" clause. (Well, I thought it could; the manual only says before.) So if it comes before then you have a line like: break *EXPRESSION thread 5 if EXPRESSION Suppose one of those expressions includes: strcmp ("thread 5", my_thread_name) Picking out the thread number would require at least lexing, and possibly parsing. -- Daniel Jacobowitz CodeSourcery, LLC